From 9fa27f3be3f45a211aec7cb0d56a8d3ddf1eb65b Mon Sep 17 00:00:00 2001 From: Paul Vriens Date: Sun, 12 Nov 2006 17:55:09 +0100 Subject: [PATCH] rsaenh: Move type-check before len-check (Coverity). --- dlls/rsaenh/rsa.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/dlls/rsaenh/rsa.c b/dlls/rsaenh/rsa.c index 4d6cd03ad2c..00a65e51f06 100644 --- a/dlls/rsaenh/rsa.c +++ b/dlls/rsaenh/rsa.c @@ -62,12 +62,6 @@ int rand_prime(mp_int *N, long len) { int type; - /* allow sizes between 2 and 256 bytes for a prime size */ - if (len < 16 || len > 8192) { - printf("Invalid prime size!\n"); - return CRYPT_INVALID_PRIME_SIZE; - } - /* get type */ if (len < 0) { type = LTM_PRIME_BBS; @@ -78,6 +72,12 @@ int rand_prime(mp_int *N, long len) /* Original LibTomCrypt: type = 0; */ } + /* allow sizes between 2 and 256 bytes for a prime size */ + if (len < 16 || len > 8192) { + printf("Invalid prime size!\n"); + return CRYPT_INVALID_PRIME_SIZE; + } + /* New prime generation makes the code even more cryptoish-insane. Do you know what this means!!! -- Gir: Yeah, oh wait, er, no. */