From 8b154a590edc9e773521e94e4f4176cf258b3ff5 Mon Sep 17 00:00:00 2001 From: Vincent Povirk Date: Sun, 6 Dec 2009 20:07:40 -0600 Subject: [PATCH] gdiplus: Fix cleanup after errors in GdipCloneImage. --- dlls/gdiplus/image.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/dlls/gdiplus/image.c b/dlls/gdiplus/image.c index 22895c7d0cb..73a6bd659ee 100644 --- a/dlls/gdiplus/image.c +++ b/dlls/gdiplus/image.c @@ -746,12 +746,14 @@ GpStatus WINGDIPAPI GdipCloneImage(GpImage *image, GpImage **cloneImage) GdipBitmapUnlockBits((GpBitmap*)*cloneImage, &lockeddata_dst); } - GdipBitmapUnlockBits(bitmap, &lockeddata_src); + if (stat != Ok) + GdipDisposeImage(*cloneImage); } + GdipBitmapUnlockBits(bitmap, &lockeddata_src); + if (stat != Ok) { - GdipDisposeImage(*cloneImage); *cloneImage = NULL; } else memcpy(&(*cloneImage)->format, &image->format, sizeof(GUID));