ReceiveTempSMS
/
Sweden-Number
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

We need to make a copy of the fontname and the HFONT handle in 

IFont_Clone, otherwise we get memory corruption and bad GDI handles.
This commit is contained in:
Marcus Meissner 2001-08-20 17:59:10 +00:00 committed by Alexandre Julliard
parent b3ec03092f
commit 872097ccd4
1 changed files with 34 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

36
dlls/oleaut32/olefont.c
View File

@ -951,6 +951,9 @@ static HRESULT WINAPI OLEFontImpl_Clone(
IFont** ppfont) IFont** ppfont)
{ {
OLEFontImpl* newObject = 0; OLEFontImpl* newObject = 0;
LOGFONTW logFont;
INT fontHeight;
CY cySize;
_ICOM_THIS(OLEFontImpl, iface); _ICOM_THIS(OLEFontImpl, iface);
TRACE("(%p)->(%p)\n", this, ppfont); TRACE("(%p)->(%p)\n", this, ppfont);
@ -969,9 +972,38 @@ static HRESULT WINAPI OLEFontImpl_Clone(
*newObject = *this; *newObject = *this;
/* /* We need to alloc new memory for the string, otherwise
* That new object starts with a reference count of 1 * we free memory twice.
*/ */
newObject->description.lpstrName = HeapAlloc(
GetProcessHeap(),0,
(1+strlenW(this->description.lpstrName))*2
);
/* We need to clone the HFONT too. This is just cut & paste from above */
IFont_get_Size(iface, &cySize);
fontHeight = MulDiv(cySize.s.Lo, 2540L, 72L);
fontHeight = MulDiv(fontHeight, this->cyLogical,this->cyHimetric);
memset(&logFont, 0, sizeof(LOGFONTW));
logFont.lfHeight = ((fontHeight%10000L)>5000L) ? (-fontHeight/10000L)-1 :
(-fontHeight/10000L);
logFont.lfItalic = this->description.fItalic;
logFont.lfUnderline = this->description.fUnderline;
logFont.lfStrikeOut = this->description.fStrikethrough;
logFont.lfWeight = this->description.sWeight;
logFont.lfCharSet = this->description.sCharset;
logFont.lfOutPrecision = OUT_CHARACTER_PRECIS;
logFont.lfClipPrecision = CLIP_DEFAULT_PRECIS;
logFont.lfQuality = DEFAULT_QUALITY;
logFont.lfPitchAndFamily = DEFAULT_PITCH;
strcpyW(logFont.lfFaceName,this->description.lpstrName);
newObject->gdiFont = CreateFontIndirectW(&logFont);
/* The cloned object starts with a reference count of 1 */
newObject->ref = 1; newObject->ref = 1;
*ppfont = (IFont*)newObject; *ppfont = (IFont*)newObject;