diff --git a/dlls/setupapi/devinst.c b/dlls/setupapi/devinst.c index bf952eff865..25fa0b56479 100644 --- a/dlls/setupapi/devinst.c +++ b/dlls/setupapi/devinst.c @@ -3118,14 +3118,14 @@ BOOL WINAPI SetupDiGetDeviceRegistryPropertyA( LONG l = RegQueryValueExA(devInfo->key, PropertyMap[Property].nameA, NULL, PropertyRegDataType, PropertyBuffer, &size); - if (RequiredSize) - *RequiredSize = size; - if (!PropertyBuffer) - ; /* do nothing, ret is already FALSE, last error is already set */ + if (l == ERROR_MORE_DATA || !PropertyBufferSize) + SetLastError(ERROR_INSUFFICIENT_BUFFER); else if (!l) ret = TRUE; else SetLastError(l); + if (RequiredSize) + *RequiredSize = size; } return ret; } @@ -3174,14 +3174,14 @@ BOOL WINAPI SetupDiGetDeviceRegistryPropertyW( LONG l = RegQueryValueExW(devInfo->key, PropertyMap[Property].nameW, NULL, PropertyRegDataType, PropertyBuffer, &size); - if (RequiredSize) - *RequiredSize = size; - if (!PropertyBuffer) - ; /* do nothing, ret is already FALSE, last error is already set */ + if (l == ERROR_MORE_DATA || !PropertyBufferSize) + SetLastError(ERROR_INSUFFICIENT_BUFFER); else if (!l) ret = TRUE; else SetLastError(l); + if (RequiredSize) + *RequiredSize = size; } return ret; } diff --git a/dlls/setupapi/tests/devinst.c b/dlls/setupapi/tests/devinst.c index 6edfd2dad88..b55565de696 100644 --- a/dlls/setupapi/tests/devinst.c +++ b/dlls/setupapi/tests/devinst.c @@ -923,7 +923,6 @@ static void testDeviceRegistryPropertyA() SetLastError(0xdeadbeef); ret = pSetupDiGetDeviceRegistryPropertyA(set, &devInfo, SPDRP_FRIENDLYNAME, NULL, NULL, 0, &size); - todo_wine ok(!ret && GetLastError() == ERROR_INSUFFICIENT_BUFFER, "Expected ERROR_INSUFFICIENT_BUFFER, got %08x\n", GetLastError()); ok(buflen == size, "Unexpected size: %d\n", size); @@ -1018,7 +1017,6 @@ static void testDeviceRegistryPropertyW() SetLastError(0xdeadbeef); ret = pSetupDiGetDeviceRegistryPropertyW(set, &devInfo, SPDRP_FRIENDLYNAME, NULL, NULL, 0, &size); - todo_wine ok(!ret && GetLastError() == ERROR_INSUFFICIENT_BUFFER, "Expected ERROR_INSUFFICIENT_BUFFER, got %08x\n", GetLastError()); ok(buflen == size, "Unexpected size: %d\n", size);