ReceiveTempSMS
/
Sweden-Number
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

d3d8/tests: Ignore random testbot failures in test_cursor. 

Signed-off-by: Stefan Dösinger <stefan@codeweavers.com>
Signed-off-by: Henri Verbeet <hverbeet@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
This commit is contained in:
Stefan Dösinger 2022-01-29 15:00:26 +03:00 committed by Alexandre Julliard
parent ef2943d166
commit 83285d54bd
1 changed files with 10 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
dlls/d3d8/tests/device.c
View File

@ -1074,11 +1074,19 @@ static void test_cursor(void)
IDirect3DSurface8_Release(cursor);
/* On the testbot the cursor handle does not behave as expected in rare situations,
* leading to random test failures. Either the cursor handle changes before we expect
* it to, or it doesn't change afterwards (or already changed before we read the
* initial handle?). I was not able to reproduce this on my own machines. Moving the
* mouse outside the window results in similar behavior. However, I tested various
* obvious failure causes: Was the mouse moved? Was the window hidden or moved? Is
* the window in the background? Neither of those applies. Making the window topmost
* or using a fullscreen device doesn't improve the test's reliability either. */
memset(&info, 0, sizeof(info));
info.cbSize = sizeof(info);
ok(GetCursorInfo(&info), "GetCursorInfo failed\n");
ok(info.flags & (CURSOR_SHOWING|CURSOR_SUPPRESSED), "The gdi cursor is hidden (%08x)\n", info.flags);
ok(info.hCursor == cur, "The cursor handle is %p\n", info.hCursor); /* unchanged */
ok(info.hCursor == cur || broken(1), "The cursor handle is %p\n", info.hCursor); /* unchanged */
/* Still hidden */
ret = IDirect3DDevice8_ShowCursor(device, TRUE);
@ -1092,7 +1100,7 @@ static void test_cursor(void)
info.cbSize = sizeof(info);
ok(GetCursorInfo(&info), "GetCursorInfo failed\n");
ok(info.flags & (CURSOR_SHOWING|CURSOR_SUPPRESSED), "The gdi cursor is hidden (%08x)\n", info.flags);
ok(info.hCursor != cur, "The cursor handle is %p\n", info.hCursor);
ok(info.hCursor != cur || broken(1), "The cursor handle is %p\n", info.hCursor);
/* Cursor dimensions must all be powers of two */
for (test_idx = 0; test_idx < ARRAY_SIZE(cursor_sizes); ++test_idx)