ReceiveTempSMS
/
Sweden-Number
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

user32: Handle HeapReAlloc failure in RemoveMenu. 

The array size is being decreased so failure is not critical here, but
it can still happen, e.g. when DPH is in use.

Signed-off-by: Thomas Faber <thomas.faber@reactos.org>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
This commit is contained in:
Thomas Faber 2018-02-03 10:47:01 +01:00 committed by Alexandre Julliard
parent d186f681fb
commit 7ee4588c0a
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
dlls/user32/menu.c
View File

@ -3989,14 +3989,16 @@ BOOL WINAPI RemoveMenu( HMENU hMenu, UINT nPos, UINT wFlags )
} }
else else
{ {
MENUITEM *new_items;
while(nPos < menu->nItems) while(nPos < menu->nItems)
{ {
*item = *(item+1); *item = *(item+1);
item++; item++;
nPos++; nPos++;
} }
menu->items = HeapReAlloc( GetProcessHeap(), 0, menu->items, new_items = HeapReAlloc( GetProcessHeap(), 0, menu->items,
menu->nItems * sizeof(MENUITEM) ); menu->nItems * sizeof(MENUITEM) );
if (new_items) menu->items = new_items;
} }
return TRUE; return TRUE;
} }