ReceiveTempSMS
/
Sweden-Number
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Fix potential race in IPinImpl_ConnectedTo.

This commit is contained in:
Robert Shearman 2004-08-16 21:07:22 +00:00 committed by Alexandre Julliard
parent c626491bf1
commit 7deab42609
1 changed files with 13 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
dlls/quartz/pin.c
View File

@ -247,19 +247,25 @@ HRESULT WINAPI IPinImpl_Disconnect(IPin * iface)
HRESULT WINAPI IPinImpl_ConnectedTo(IPin * iface, IPin ** ppPin) HRESULT WINAPI IPinImpl_ConnectedTo(IPin * iface, IPin ** ppPin)
{ {
HRESULT hr;
ICOM_THIS(IPinImpl, iface); ICOM_THIS(IPinImpl, iface);
/* TRACE("(%p)\n", ppPin);*/ /* TRACE("(%p)\n", ppPin);*/
*ppPin = This->pConnectedTo; EnterCriticalSection(This->pCritSec);
if (*ppPin)
{ {
IPin_AddRef(*ppPin); if (This->pConnectedTo)
return S_OK; {
*ppPin = This->pConnectedTo;
IPin_AddRef(*ppPin);
hr = S_OK;
}
else
hr = VFW_E_NOT_CONNECTED;
} }
else LeaveCriticalSection(This->pCritSec);
return VFW_E_NOT_CONNECTED;
return hr;
} }
HRESULT WINAPI IPinImpl_ConnectionMediaType(IPin * iface, AM_MEDIA_TYPE * pmt) HRESULT WINAPI IPinImpl_ConnectionMediaType(IPin * iface, AM_MEDIA_TYPE * pmt)