ReceiveTempSMS
/
Sweden-Number
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

shell32: Fix memory leak on NULL return length (Coverity).

This commit is contained in:
Nikolay Sivov 2015-06-27 22:07:39 +03:00 committed by Alexandre Julliard
parent 64456de761
commit 7ca31b8119
1 changed files with 3 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
dlls/shell32/assoc.c
View File

@ -745,7 +745,7 @@ static HRESULT WINAPI IQueryAssociations_fnGetData(IQueryAssociations *iface,
static const WCHAR edit_flags[] = {'E','d','i','t','F','l','a','g','s',0}; static const WCHAR edit_flags[] = {'E','d','i','t','F','l','a','g','s',0};
IQueryAssociationsImpl *This = impl_from_IQueryAssociations(iface); IQueryAssociationsImpl *This = impl_from_IQueryAssociations(iface);
void *data; void *data = NULL;
DWORD size; DWORD size;
HRESULT hres; HRESULT hres;
@ -761,10 +761,8 @@ static HRESULT WINAPI IQueryAssociations_fnGetData(IQueryAssociations *iface,
return HRESULT_FROM_WIN32(ERROR_NO_ASSOCIATION); return HRESULT_FROM_WIN32(ERROR_NO_ASSOCIATION);
hres = ASSOC_GetValue(This->hkeyProgID, edit_flags, &data, &size); hres = ASSOC_GetValue(This->hkeyProgID, edit_flags, &data, &size);
if(FAILED(hres) || !pcbOut) if(SUCCEEDED(hres) && pcbOut)
return hres; hres = ASSOC_ReturnData(pvOut, pcbOut, data, size);
hres = ASSOC_ReturnData(pvOut, pcbOut, data, size);
HeapFree(GetProcessHeap(), 0, data); HeapFree(GetProcessHeap(), 0, data);
return hres; return hres;
default: default: