ReceiveTempSMS/Sweden-Number
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

itss: Reorder some code to avoid leaking memory on an error path.

Browse Source 
Found by Smatch.
This commit is contained in:
Michael Stefaniuc 2010-02-09 23:01:26 +01:00 committed by Alexandre Julliard
parent e0b23217fe
commit 7a8638d8b3
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
dlls/itss/storage.c
View File

@ -399,6 +399,10 @@ static HRESULT WINAPI ITSS_IStorageImpl_OpenStorage(
TRACE("%p %s %p %u %p %u %p\n", This, debugstr_w(pwcsName), TRACE("%p %s %p %u %p %u %p\n", This, debugstr_w(pwcsName),
pstgPriority, grfMode, snbExclude, reserved, ppstg); pstgPriority, grfMode, snbExclude, reserved, ppstg);
chmfile = chm_dup( This->chmfile );
if( !chmfile )
return E_FAIL;
len = strlenW( This->dir ) + strlenW( pwcsName ) + 1; len = strlenW( This->dir ) + strlenW( pwcsName ) + 1;
path = HeapAlloc( GetProcessHeap(), 0, len*sizeof(WCHAR) ); path = HeapAlloc( GetProcessHeap(), 0, len*sizeof(WCHAR) );
strcpyW( path, This->dir ); strcpyW( path, This->dir );
@ -423,9 +427,6 @@ static HRESULT WINAPI ITSS_IStorageImpl_OpenStorage(
TRACE("Resolving %s\n", debugstr_w(path)); TRACE("Resolving %s\n", debugstr_w(path));
chmfile = chm_dup( This->chmfile );
if( !chmfile )
return E_FAIL;
return ITSS_create_chm_storage(chmfile, path, ppstg); return ITSS_create_chm_storage(chmfile, path, ppstg);
} }