ReceiveTempSMS
/
Sweden-Number
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

quartz: Handle freeing pins in error case (Coverity).

This commit is contained in:
Marcus Meissner 2012-09-02 14:57:15 +02:00 committed by Alexandre Julliard
parent c7355f7921
commit 791bc1cb93
1 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
dlls/quartz/filtergraph.c
View File

@ -906,12 +906,13 @@ static HRESULT WINAPI FilterGraph2_Connect(IFilterGraph2 *iface, IPin *ppinOut,
IEnumPins* penumpins; IEnumPins* penumpins;
IEnumMoniker* pEnumMoniker; IEnumMoniker* pEnumMoniker;
GUID tab[2]; GUID tab[2];
ULONG nb; ULONG nb = 0;
IMoniker* pMoniker; IMoniker* pMoniker;
ULONG pin; ULONG pin;
PIN_INFO PinInfo; PIN_INFO PinInfo;
CLSID FilterCLSID; CLSID FilterCLSID;
PIN_DIRECTION dir; PIN_DIRECTION dir;
unsigned int i = 0;
TRACE("(%p/%p)->(%p, %p)\n", This, iface, ppinOut, ppinIn); TRACE("(%p/%p)->(%p, %p)\n", This, iface, ppinOut, ppinIn);
@ -1012,7 +1013,7 @@ static HRESULT WINAPI FilterGraph2_Connect(IFilterGraph2 *iface, IPin *ppinOut,
{ {
VARIANT var; VARIANT var;
GUID clsid; GUID clsid;
IPin** ppins; IPin** ppins = NULL;
IPin* ppinfilter = NULL; IPin* ppinfilter = NULL;
IBaseFilter* pfilter = NULL; IBaseFilter* pfilter = NULL;
IAMGraphBuilderCallback *callback = NULL; IAMGraphBuilderCallback *callback = NULL;
@ -1104,7 +1105,6 @@ static HRESULT WINAPI FilterGraph2_Connect(IFilterGraph2 *iface, IPin *ppinOut,
hr = GetInternalConnections(pfilter, ppinfilter, &ppins, &nb); hr = GetInternalConnections(pfilter, ppinfilter, &ppins, &nb);
if (SUCCEEDED(hr)) { if (SUCCEEDED(hr)) {
unsigned int i;
if (nb == 0) { if (nb == 0) {
IPin_Disconnect(ppinfilter); IPin_Disconnect(ppinfilter);
IPin_Disconnect(ppinOut); IPin_Disconnect(ppinOut);
@ -1157,6 +1157,8 @@ error:
IFilterGraph2_RemoveFilter(iface, pfilter); IFilterGraph2_RemoveFilter(iface, pfilter);
IBaseFilter_Release(pfilter); IBaseFilter_Release(pfilter);
} }
while (++i < nb) IPin_Release(ppins[i]);
CoTaskMemFree(ppins);
} }
out: out: