From 7728acd1b6994c553a046e3ff9ee1aebc20c38b6 Mon Sep 17 00:00:00 2001 From: Zebediah Figura Date: Sat, 26 Jan 2019 16:59:00 -0600 Subject: [PATCH] msi: Remove an unnecessary call to SELECT_get_dimensions(). Signed-off-by: Zebediah Figura Signed-off-by: Hans Leidekker Signed-off-by: Alexandre Julliard --- dlls/msi/select.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/dlls/msi/select.c b/dlls/msi/select.c index 99339c24b89..c6e7b209033 100644 --- a/dlls/msi/select.c +++ b/dlls/msi/select.c @@ -233,14 +233,10 @@ static UINT SELECT_get_column_info( struct tagMSIVIEW *view, UINT n, LPCWSTR *na static UINT msi_select_update(struct tagMSIVIEW *view, MSIRECORD *rec, UINT row) { MSISELECTVIEW *sv = (MSISELECTVIEW*)view; - UINT r, i, num_columns, col, type, val; + UINT r, i, col, type, val; LPCWSTR str; - r = SELECT_get_dimensions(view, NULL, &num_columns); - if (r != ERROR_SUCCESS) - return r; - - for (i = 0; i < num_columns; i++) + for (i = 0; i < sv->num_cols; i++) { col = sv->cols[i];