ReceiveTempSMS
/
Sweden-Number
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

shell32/tests: Minor test file cleanup.

This commit is contained in:
Nikolay Sivov 2010-03-03 00:00:52 +03:00 committed by Alexandre Julliard
parent 5a1f8c57a8
commit 721be7135f
1 changed files with 40 additions and 26 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

66
dlls/shell32/tests/shlfolder.c
View File

@ -62,17 +62,23 @@ static void init_function_pointers(void)
HRESULT hr; HRESULT hr;
hmod = GetModuleHandleA("shell32.dll"); hmod = GetModuleHandleA("shell32.dll");
pSHBindToParent = (void*)GetProcAddress(hmod, "SHBindToParent");
pSHGetFolderPathA = (void*)GetProcAddress(hmod, "SHGetFolderPathA"); #define MAKEFUNC(f) (p##f = (void*)GetProcAddress(hmod, #f))
pSHGetFolderPathAndSubDirA = (void*)GetProcAddress(hmod, "SHGetFolderPathAndSubDirA"); MAKEFUNC(SHBindToParent);
pSHGetPathFromIDListW = (void*)GetProcAddress(hmod, "SHGetPathFromIDListW"); MAKEFUNC(SHCreateShellItem);
pSHGetSpecialFolderPathA = (void*)GetProcAddress(hmod, "SHGetSpecialFolderPathA"); MAKEFUNC(SHGetFolderPathA);
pSHGetSpecialFolderPathW = (void*)GetProcAddress(hmod, "SHGetSpecialFolderPathW"); MAKEFUNC(SHGetFolderPathAndSubDirA);
pILFindLastID = (void *)GetProcAddress(hmod, (LPCSTR)16); MAKEFUNC(SHGetPathFromIDListW);
pILFree = (void*)GetProcAddress(hmod, (LPSTR)155); MAKEFUNC(SHGetSpecialFolderPathA);
pILIsEqual = (void*)GetProcAddress(hmod, (LPSTR)21); MAKEFUNC(SHGetSpecialFolderPathW);
pSHCreateShellItem = (void*)GetProcAddress(hmod, "SHCreateShellItem"); #undef MAKEFUNC
pILCombine = (void*)GetProcAddress(hmod, (LPSTR)25);
#define MAKEFUNC_ORD(f, ord) (p##f = (void*)GetProcAddress(hmod, (LPSTR)(ord)))
MAKEFUNC_ORD(ILFindLastID, 16);
MAKEFUNC_ORD(ILIsEqual, 21);
MAKEFUNC_ORD(ILCombine, 25);
MAKEFUNC_ORD(ILFree, 155);
#undef MAKEFUNC_ORD
hmod = GetModuleHandleA("shlwapi.dll"); hmod = GetModuleHandleA("shlwapi.dll");
pStrRetToBufW = (void*)GetProcAddress(hmod, "StrRetToBufW"); pStrRetToBufW = (void*)GetProcAddress(hmod, "StrRetToBufW");
@ -331,11 +337,12 @@ static void test_BindToObject(void)
hr = IShellFolder_BindToObject(psfMyComputer, pidlEmpty, NULL, &IID_IShellFolder, (LPVOID*)&psfChild); hr = IShellFolder_BindToObject(psfMyComputer, pidlEmpty, NULL, &IID_IShellFolder, (LPVOID*)&psfChild);
ok (hr == E_INVALIDARG, "MyComputers's BindToObject should fail, when called with empty pidl! hr = %08x\n", hr); ok (hr == E_INVALIDARG, "MyComputers's BindToObject should fail, when called with empty pidl! hr = %08x\n", hr);
#if 0 if (0)
{
/* this call segfaults on 98SE */ /* this call segfaults on 98SE */
hr = IShellFolder_BindToObject(psfMyComputer, NULL, NULL, &IID_IShellFolder, (LPVOID*)&psfChild); hr = IShellFolder_BindToObject(psfMyComputer, NULL, NULL, &IID_IShellFolder, (LPVOID*)&psfChild);
ok (hr == E_INVALIDARG, "MyComputers's BindToObject should fail, when called with NULL pidl! hr = %08x\n", hr); ok (hr == E_INVALIDARG, "MyComputers's BindToObject should fail, when called with NULL pidl! hr = %08x\n", hr);
#endif }
cChars = GetSystemDirectoryA(szSystemDir, MAX_PATH); cChars = GetSystemDirectoryA(szSystemDir, MAX_PATH);
ok (cChars > 0 && cChars < MAX_PATH, "GetSystemDirectoryA failed! LastError: %u\n", GetLastError()); ok (cChars > 0 && cChars < MAX_PATH, "GetSystemDirectoryA failed! LastError: %u\n", GetLastError());
@ -361,13 +368,14 @@ static void test_BindToObject(void)
hr = IShellFolder_BindToObject(psfSystemDir, pidlEmpty, NULL, &IID_IShellFolder, (LPVOID*)&psfChild); hr = IShellFolder_BindToObject(psfSystemDir, pidlEmpty, NULL, &IID_IShellFolder, (LPVOID*)&psfChild);
ok (hr == E_INVALIDARG, ok (hr == E_INVALIDARG,
"FileSystem ShellFolder's BindToObject should fail, when called with empty pidl! hr = %08x\n", hr); "FileSystem ShellFolder's BindToObject should fail, when called with empty pidl! hr = %08x\n", hr);
#if 0 if (0)
{
/* this call segfaults on 98SE */ /* this call segfaults on 98SE */
hr = IShellFolder_BindToObject(psfSystemDir, NULL, NULL, &IID_IShellFolder, (LPVOID*)&psfChild); hr = IShellFolder_BindToObject(psfSystemDir, NULL, NULL, &IID_IShellFolder, (LPVOID*)&psfChild);
ok (hr == E_INVALIDARG, ok (hr == E_INVALIDARG,
"FileSystem ShellFolder's BindToObject should fail, when called with NULL pidl! hr = %08x\n", hr); "FileSystem ShellFolder's BindToObject should fail, when called with NULL pidl! hr = %08x\n", hr);
#endif }
IShellFolder_Release(psfSystemDir); IShellFolder_Release(psfSystemDir);
} }
@ -1564,7 +1572,7 @@ static void test_ITEMIDLIST_format(void) {
IShellFolder_Release(psfPersonal); IShellFolder_Release(psfPersonal);
} }
static void testSHGetFolderPathAndSubDirA(void) static void test_SHGetFolderPathAndSubDirA(void)
{ {
HRESULT ret; HRESULT ret;
BOOL delret; BOOL delret;
@ -1576,6 +1584,12 @@ static void testSHGetFolderPathAndSubDirA(void)
static char testpath[MAX_PATH]; static char testpath[MAX_PATH];
static char toolongpath[MAX_PATH+1]; static char toolongpath[MAX_PATH+1];
if(!pSHGetFolderPathAndSubDirA)
{
win_skip("SHGetFolderPathAndSubDirA not present!\n");
return;
}
if(!pSHGetFolderPathA) { if(!pSHGetFolderPathA) {
win_skip("SHGetFolderPathA not present!\n"); win_skip("SHGetFolderPathA not present!\n");
return; return;
@ -1797,6 +1811,12 @@ static void test_SHCreateShellItem(void)
GetCurrentDirectoryA(MAX_PATH, curdirA); GetCurrentDirectoryA(MAX_PATH, curdirA);
if (!pSHCreateShellItem)
{
win_skip("SHCreateShellItem isn't available\n");
return;
}
if (!lstrlenA(curdirA)) if (!lstrlenA(curdirA))
{ {
win_skip("GetCurrentDirectoryA returned empty string, skipping test_SHCreateShellItem\n"); win_skip("GetCurrentDirectoryA returned empty string, skipping test_SHCreateShellItem\n");
@ -1958,15 +1978,9 @@ START_TEST(shlfolder)
test_CallForAttributes(); test_CallForAttributes();
test_FolderShortcut(); test_FolderShortcut();
test_ITEMIDLIST_format(); test_ITEMIDLIST_format();
if(pSHGetFolderPathAndSubDirA) test_SHGetFolderPathAndSubDirA();
testSHGetFolderPathAndSubDirA();
else
win_skip("SHGetFolderPathAndSubDirA not present\n");
test_LocalizedNames(); test_LocalizedNames();
if(pSHCreateShellItem) test_SHCreateShellItem();
test_SHCreateShellItem();
else
win_skip("SHCreateShellItem not present\n");
OleUninitialize(); OleUninitialize();
} }