From 7153c8fa650e04650e8f3f1de30b4ce87dd20de1 Mon Sep 17 00:00:00 2001
From: Mike McCormack <mike@codeweavers.com>
Date: Mon, 23 May 2005 09:53:43 +0000
Subject: [PATCH] - remove the unused utf8 field of an expression - make the
 parse result a single assignment at top level of parsing - abort parsing on a
 memory allocation failure

---
 dlls/msi/msipriv.h  |  2 +-
 dlls/msi/msiquery.c |  2 +-
 dlls/msi/query.h    |  2 --
 dlls/msi/sql.y      | 56 ++++++++++++++++++++++++++-------------------
 4 files changed, 34 insertions(+), 28 deletions(-)

diff --git a/dlls/msi/msipriv.h b/dlls/msi/msipriv.h
index 42443c1e0b5..a2087681e6e 100644
--- a/dlls/msi/msipriv.h
+++ b/dlls/msi/msipriv.h
@@ -288,7 +288,7 @@ extern const WCHAR *msi_string_lookup_id( string_table *st, UINT id );
 extern UINT msi_string_get_codepage( string_table *st );
 
 
-extern UINT VIEW_find_column( MSIVIEW *view, LPWSTR name, UINT *n );
+extern UINT VIEW_find_column( MSIVIEW *view, LPCWSTR name, UINT *n );
 
 extern BOOL TABLE_Exists( MSIDATABASE *db, LPWSTR name );
 
diff --git a/dlls/msi/msiquery.c b/dlls/msi/msiquery.c
index 15e1138af9d..be07b34f0b2 100644
--- a/dlls/msi/msiquery.c
+++ b/dlls/msi/msiquery.c
@@ -47,7 +47,7 @@ void MSI_CloseView( MSIOBJECTHDR *arg )
     msiobj_release( &query->db->hdr );
 }
 
-UINT VIEW_find_column( MSIVIEW *table, LPWSTR name, UINT *n )
+UINT VIEW_find_column( MSIVIEW *table, LPCWSTR name, UINT *n )
 {
     LPWSTR col_name;
     UINT i, count, r;
diff --git a/dlls/msi/query.h b/dlls/msi/query.h
index e8ff5cd8f9c..46c800cb892 100644
--- a/dlls/msi/query.h
+++ b/dlls/msi/query.h
@@ -50,7 +50,6 @@
 #define EXPR_SVAL     5
 #define EXPR_UVAL     6
 #define EXPR_STRCMP   7
-#define EXPR_UTF8     8
 #define EXPR_WILDCARD 9
 #define EXPR_COL_NUMBER_STRING 10
 
@@ -83,7 +82,6 @@ struct expr
         LPWSTR sval;
         LPWSTR column;
         UINT col_number;
-        char *utf8;
     } u;
 };
 
diff --git a/dlls/msi/sql.y b/dlls/msi/sql.y
index 41764281bdc..79bf5febf4e 100644
--- a/dlls/msi/sql.y
+++ b/dlls/msi/sql.y
@@ -129,8 +129,8 @@ static struct expr * EXPR_wildcard();
 
 %type <string> column table id
 %type <column_list> selcollist
-%type <query> from unorderedsel oneselect onequery onecreate oneinsert
-%type <query> oneupdate onedelete
+%type <query> query from unorderedsel
+%type <query> oneupdate onedelete oneselect onequery onecreate oneinsert
 %type <expr> expr val column_val const_val
 %type <column_type> column_type data_type data_type_l data_count
 %type <column_info> column_def table_def
@@ -139,32 +139,20 @@ static struct expr * EXPR_wildcard();
 
 %%
 
+query:
+    onequery
+    {
+        SQL_input* sql = (SQL_input*) info;
+        *sql->view = $1;
+    }
+    ;
+
 onequery:
     oneselect
-    {
-        SQL_input* sql = (SQL_input*) info;
-        *sql->view = $1;
-    }
   | onecreate
-    {
-        SQL_input* sql = (SQL_input*) info;
-        *sql->view = $1;
-    }
   | oneinsert
-    {
-        SQL_input* sql = (SQL_input*) info;
-        *sql->view = $1;
-    }
   | oneupdate
-    {
-        SQL_input* sql = (SQL_input*) info;
-        *sql->view = $1;
-    }
   | onedelete
-    {
-        SQL_input* sql = (SQL_input*) info;
-        *sql->view = $1;
-    }
     ;
 
 oneinsert:
@@ -455,46 +443,68 @@ expr:
   | column_val TK_EQ column_val
         {
             $$ = EXPR_complex( $1, OP_EQ, $3 );
+            if( !$$ )
+                YYABORT;
         }
   | expr TK_AND expr
         {
             $$ = EXPR_complex( $1, OP_AND, $3 );
+            if( !$$ )
+                YYABORT;
         }
   | expr TK_OR expr
         {
             $$ = EXPR_complex( $1, OP_OR, $3 );
+            if( !$$ )
+                YYABORT;
         }
   | column_val TK_EQ val
         {
             $$ = EXPR_complex( $1, OP_EQ, $3 );
+            if( !$$ )
+                YYABORT;
         }
   | column_val TK_GT val
         {
             $$ = EXPR_complex( $1, OP_GT, $3 );
+            if( !$$ )
+                YYABORT;
         }
   | column_val TK_LT val
         {
             $$ = EXPR_complex( $1, OP_LT, $3 );
+            if( !$$ )
+                YYABORT;
         }
   | column_val TK_LE val
         {
             $$ = EXPR_complex( $1, OP_LE, $3 );
+            if( !$$ )
+                YYABORT;
         }
   | column_val TK_GE val
         {
             $$ = EXPR_complex( $1, OP_GE, $3 );
+            if( !$$ )
+                YYABORT;
         }
   | column_val TK_NE val
         {
             $$ = EXPR_complex( $1, OP_NE, $3 );
+            if( !$$ )
+                YYABORT;
         }
   | column_val TK_IS TK_NULL
         {
             $$ = EXPR_complex( $1, OP_ISNULL, NULL );
+            if( !$$ )
+                YYABORT;
         }
   | column_val TK_IS TK_NOT TK_NULL
         {
             $$ = EXPR_complex( $1, OP_NOTNULL, NULL );
+            if( !$$ )
+                YYABORT;
         }
     ;
 
@@ -764,8 +774,6 @@ void delete_expr( struct expr *e )
         delete_expr( e->u.expr.left );
         delete_expr( e->u.expr.right );
     }
-    else if( e->type == EXPR_UTF8 )
-        HeapFree( GetProcessHeap(), 0, e->u.utf8 );
     else if( e->type == EXPR_SVAL )
         HeapFree( GetProcessHeap(), 0, e->u.sval );
     HeapFree( GetProcessHeap(), 0, e );