From 701991ca326c47c158d85760c33b10f7550a8cad Mon Sep 17 00:00:00 2001 From: Alistair Leslie-Hughes Date: Sat, 16 Feb 2008 22:02:40 +1100 Subject: [PATCH] msxml3: Implement IXMLDOMProcessingInstruction target. --- dlls/msxml3/pi.c | 5 +++-- dlls/msxml3/tests/domdoc.c | 12 ++++++++++++ 2 files changed, 15 insertions(+), 2 deletions(-) diff --git a/dlls/msxml3/pi.c b/dlls/msxml3/pi.c index 054d7f852b5..11296903a43 100644 --- a/dlls/msxml3/pi.c +++ b/dlls/msxml3/pi.c @@ -433,8 +433,9 @@ static HRESULT WINAPI dom_pi_get_target( IXMLDOMProcessingInstruction *iface, BSTR *p) { - FIXME("\n"); - return E_NOTIMPL; + /* target returns the same value as nodeName property */ + dom_pi *This = impl_from_IXMLDOMProcessingInstruction( iface ); + return IXMLDOMNode_get_nodeName( This->node, p ); } static HRESULT WINAPI dom_pi_get_data( diff --git a/dlls/msxml3/tests/domdoc.c b/dlls/msxml3/tests/domdoc.c index cbc7c6bdf59..424de185668 100644 --- a/dlls/msxml3/tests/domdoc.c +++ b/dlls/msxml3/tests/domdoc.c @@ -618,6 +618,18 @@ static void test_domdoc( void ) ok( V_VT(&var) == VT_NULL, "incorrect dataType type\n"); VariantClear(&var); + /* test nodeName */ + r = IXMLDOMProcessingInstruction_get_nodeName(nodePI, &str); + ok(r == S_OK, "ret %08x\n", r ); + ok( !lstrcmpW( str, _bstr_("xml") ), "incorrect nodeName string\n"); + SysFreeString(str); + + /* test Target */ + r = IXMLDOMProcessingInstruction_get_target(nodePI, &str); + ok(r == S_OK, "ret %08x\n", r ); + ok( !lstrcmpW( str, _bstr_("xml") ), "incorrect target string\n"); + SysFreeString(str); + /* test nodeTypeString */ r = IXMLDOMProcessingInstruction_get_nodeTypeString(nodePI, &str); ok(r == S_OK, "ret %08x\n", r );