taskschd: IRegistrationInfo::put_Documentation() should accept NULL input.
Signed-off-by: Dmitry Timoshkov <dmitry@baikal.ru> Signed-off-by: Alexandre Julliard <julliard@winehq.org>
This commit is contained in:
parent
57c936b05c
commit
62ea04298b
|
@ -689,15 +689,14 @@ static HRESULT WINAPI RegistrationInfo_get_Documentation(IRegistrationInfo *ifac
|
|||
static HRESULT WINAPI RegistrationInfo_put_Documentation(IRegistrationInfo *iface, BSTR doc)
|
||||
{
|
||||
registration_info *reginfo = impl_from_IRegistrationInfo(iface);
|
||||
WCHAR *str = NULL;
|
||||
|
||||
TRACE("%p,%s\n", iface, debugstr_w(doc));
|
||||
|
||||
if (!doc) return E_INVALIDARG;
|
||||
|
||||
if (doc && !(str = heap_strdupW(doc))) return E_OUTOFMEMORY;
|
||||
heap_free(reginfo->documentation);
|
||||
reginfo->documentation = heap_strdupW(doc);
|
||||
/* FIXME: update XML on the server side */
|
||||
return reginfo->documentation ? S_OK : E_OUTOFMEMORY;
|
||||
reginfo->documentation = str;
|
||||
return S_OK;
|
||||
}
|
||||
|
||||
static HRESULT WINAPI RegistrationInfo_get_XmlText(IRegistrationInfo *iface, BSTR *xml)
|
||||
|
@ -3331,6 +3330,12 @@ static HRESULT read_registration_info(IXmlReader *reader, IRegistrationInfo *inf
|
|||
if (hr == S_OK)
|
||||
IRegistrationInfo_put_Date(info, value);
|
||||
}
|
||||
else if (!lstrcmpW(name, Documentation))
|
||||
{
|
||||
hr = read_text_value(reader, &value);
|
||||
if (hr == S_OK)
|
||||
IRegistrationInfo_put_Documentation(info, value);
|
||||
}
|
||||
else
|
||||
FIXME("unhandled RegistrationInfo element %s\n", debugstr_w(name));
|
||||
|
||||
|
|
|
@ -1427,6 +1427,7 @@ static void test_TaskDefinition(void)
|
|||
" <Author>author</Author>\n"
|
||||
" <Version>1.0</Version>\n"
|
||||
" <Date>2018-04-02T11:22:33</Date>\n"
|
||||
" <Documentation>doc</Documentation>\n"
|
||||
" </RegistrationInfo>\n"
|
||||
" <Settings>\n"
|
||||
" <Enabled>false</Enabled>\n"
|
||||
|
@ -1509,6 +1510,7 @@ static void test_TaskDefinition(void)
|
|||
static const WCHAR authorW[] = { 'a','u','t','h','o','r',0 };
|
||||
static const WCHAR versionW[] = { '1','.','0',0 };
|
||||
static const WCHAR dateW[] = { '2','0','1','8','-','0','4','-','0','2','T','1','1',':','2','2',':','3','3',0 };
|
||||
static const WCHAR docW[] = { 'd','o','c',0 };
|
||||
static WCHAR Task1[] = { '"','T','a','s','k','1','"',0 };
|
||||
static struct settings def_settings = { { 0 }, { 'P','T','7','2','H',0 }, { 0 },
|
||||
0, 7, TASK_INSTANCES_IGNORE_NEW, TASK_COMPATIBILITY_V2, VARIANT_TRUE, VARIANT_TRUE,
|
||||
|
@ -1648,9 +1650,17 @@ todo_wine
|
|||
ok(hr == S_OK, "get_Date error %#x\n", hr);
|
||||
ok(!bstr, "expected NULL, got %s\n", wine_dbgstr_w(bstr));
|
||||
|
||||
hr = IRegistrationInfo_get_Documentation(reginfo, &bstr);
|
||||
ok(hr == S_OK, "get_Documentation error %#x\n", hr);
|
||||
ok(!lstrcmpW(bstr, docW), "expected %s, got %s\n", wine_dbgstr_w(docW), wine_dbgstr_w(bstr));
|
||||
SysFreeString(bstr);
|
||||
hr = IRegistrationInfo_put_Documentation(reginfo, NULL);
|
||||
ok(hr == S_OK, "put_Documentation error %#x\n", hr);
|
||||
bstr = (BSTR)0xdeadbeef;
|
||||
hr = IRegistrationInfo_get_Documentation(reginfo, &bstr);
|
||||
ok(hr == S_OK, "get_Documentation error %#x\n", hr);
|
||||
ok(!bstr, "expected NULL, got %s\n", wine_dbgstr_w(bstr));
|
||||
|
||||
hr = IRegistrationInfo_get_URI(reginfo, &bstr);
|
||||
ok(hr == S_OK, "get_URI error %#x\n", hr);
|
||||
ok(!bstr, "expected NULL, got %s\n", wine_dbgstr_w(bstr));
|
||||
|
|
Loading…
Reference in New Issue