ReceiveTempSMS
/
Sweden-Number
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

browseui: Avoid race-conditions when progress dialog is released before thread terminates.

This commit is contained in:
Sebastian Lackner 2015-03-01 03:52:06 +01:00 committed by Alexandre Julliard
parent 73a68b065b
commit 5ecc08e349
1 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
dlls/browseui/progressdlg.c
View File

@ -235,6 +235,7 @@ static DWORD WINAPI dialog_thread(LPVOID lpParameter)
/* Note: until we set the hEvent in WM_INITDIALOG, the ProgressDialog object
* is protected by the critical section held by StartProgress */
struct create_params *params = lpParameter;
ProgressDialog *This = params->This;
HWND hwnd;
MSG msg;
@ -252,6 +253,7 @@ static DWORD WINAPI dialog_thread(LPVOID lpParameter)
}
}
IProgressDialog_Release(&This->IProgressDialog_iface);
return 0;
}
@ -341,10 +343,14 @@ static HRESULT WINAPI ProgressDialog_StartProgressDialog(IProgressDialog *iface,
return S_OK; /* as on XP */
}
This->dwFlags = dwFlags;
params.This = This;
params.hwndParent = hwndParent;
params.hEvent = CreateEventW(NULL, TRUE, FALSE, NULL);
/* thread holds one reference to ensure clean shutdown */
IProgressDialog_AddRef(&This->IProgressDialog_iface);
hThread = CreateThread(NULL, 0, dialog_thread, &params, 0, NULL);
WaitForSingleObject(params.hEvent, INFINITE);
CloseHandle(params.hEvent);