ReceiveTempSMS
/
Sweden-Number
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

msi: Fix several memory leaks after using IEnumSTATSTG_Next. 

The pwcsName field of STATSTG must be freed, otherwise the memory will 
be leaked.
This commit is contained in:
Rob Shearman 2007-12-26 11:02:55 +00:00 committed by Alexandre Julliard
parent 1f56359261
commit 5b072fbbec
2 changed files with 7 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
dlls/msi/streams.c
View File

@ -408,17 +408,22 @@ static UINT add_streams_to_table(MSISTREAMSVIEW *sv)
/* table streams are not in the _Streams table */ /* table streams are not in the _Streams table */
if (*stat.pwcsName == 0x4840) if (*stat.pwcsName == 0x4840)
{
CoTaskMemFree(stat.pwcsName);
continue; continue;
}
stream = create_stream(sv, stat.pwcsName, TRUE, NULL); stream = create_stream(sv, stat.pwcsName, TRUE, NULL);
if (!stream) if (!stream)
{ {
count = -1; count = -1;
CoTaskMemFree(stat.pwcsName);
break; break;
} }
IStorage_OpenStream(sv->db->storage, stat.pwcsName, 0, IStorage_OpenStream(sv->db->storage, stat.pwcsName, 0,
STGM_READ | STGM_SHARE_EXCLUSIVE, 0, &stream->stream); STGM_READ | STGM_SHARE_EXCLUSIVE, 0, &stream->stream);
CoTaskMemFree(stat.pwcsName);
if (!add_stream_to_table(sv, stream, count++)) if (!add_stream_to_table(sv, stream, count++))
{ {

2
dlls/msi/table.c
View File

@ -265,6 +265,7 @@ void enum_stream_names( IStorage *stg )
decode_streamname( stat.pwcsName, name ); decode_streamname( stat.pwcsName, name );
TRACE("stream %2d -> %s %s\n", n, TRACE("stream %2d -> %s %s\n", n,
debugstr_w(stat.pwcsName), debugstr_w(name) ); debugstr_w(stat.pwcsName), debugstr_w(name) );
CoTaskMemFree( stat.pwcsName );
n++; n++;
} }
@ -2577,6 +2578,7 @@ UINT msi_table_apply_transform( MSIDATABASE *db, IStorage *stg )
break; break;
decode_streamname( stat.pwcsName, name ); decode_streamname( stat.pwcsName, name );
CoTaskMemFree( stat.pwcsName );
if ( name[0] != 0x4840 ) if ( name[0] != 0x4840 )
continue; continue;