ReceiveTempSMS
/
Sweden-Number
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

qcap: Fixed a use after free in error path (Coverity).

This commit is contained in:
Marcus Meissner 2012-08-17 23:04:31 +02:00 committed by Alexandre Julliard
parent de7635a2f0
commit 524ff6fe27
2 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
dlls/qcap/v4l.c
View File

@ -314,6 +314,7 @@ HRESULT qcap_driver_get_format(const Capture *capBox, AM_MEDIA_TYPE ** mT)
if (!vi) if (!vi)
{ {
CoTaskMemFree(mT[0]); CoTaskMemFree(mT[0]);
mT[0] = NULL;
return E_OUTOFMEMORY; return E_OUTOFMEMORY;
} }
mT[0]->majortype = MEDIATYPE_Video; mT[0]->majortype = MEDIATYPE_Video;

7
dlls/qcap/vfwcapture.c
View File

@ -678,9 +678,10 @@ static HRESULT WINAPI VfwPin_GetMediaType(BasePin *iface, int iPosition, AM_MEDI
return VFW_S_NO_MORE_ITEMS; return VFW_S_NO_MORE_ITEMS;
hr = qcap_driver_get_format(This->driver_info, &vfw_pmt); hr = qcap_driver_get_format(This->driver_info, &vfw_pmt);
CopyMediaType(pmt, vfw_pmt); if (SUCCEEDED(hr)) {
DeleteMediaType(vfw_pmt); CopyMediaType(pmt, vfw_pmt);
DeleteMediaType(vfw_pmt);
}
return hr; return hr;
} }