ReceiveTempSMS
/
Sweden-Number
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

hidclass.sys: Overwrite queued reports as FIFO instead of LIFO. 

Based on a patch from Ivo Ivanov <logos128@gmail.com>.

The issue causes severe skipping and non smooth movement tracking in
apps/games, when the HidP/HidD APIs are used to control the device
(joysticks, controllers, steering wheels, etc.).

Usually such devices use constant stream of INPUT reports to report
their coords, so any report skipping or change of the sequence,
when the interested apps are reading, would lead to such issues.

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=51824
Signed-off-by: Rémi Bernon <rbernon@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
This commit is contained in:
Rémi Bernon 2021-10-04 10:20:19 +02:00 committed by Alexandre Julliard
parent 9411ecf670
commit 51ae926240
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
dlls/hidclass.sys/device.c
View File

@ -190,10 +190,12 @@ static void hid_queue_push_report( struct hid_queue *queue, struct hid_report *r
KeAcquireSpinLock( &queue->lock, &irql ); KeAcquireSpinLock( &queue->lock, &irql );
prev = queue->reports[i]; prev = queue->reports[i];
queue->reports[i] = report; queue->reports[i] = report;
if (next != queue->read_idx) queue->write_idx = next; if (next == queue->read_idx) queue->read_idx = next + 1;
if (queue->read_idx >= queue->length) queue->read_idx = 0;
KeReleaseSpinLock( &queue->lock, irql ); KeReleaseSpinLock( &queue->lock, irql );
hid_report_decref( prev ); hid_report_decref( prev );
queue->write_idx = next;
} }
static struct hid_report *hid_queue_pop_report( struct hid_queue *queue ) static struct hid_report *hid_queue_pop_report( struct hid_queue *queue )