ReceiveTempSMS
/
Sweden-Number
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

urlmon: Fix timing issue with FLAG_REQUEST_COMPLETE and InternetQueryDataAvailable in HttpProtocol_Continue.

This commit is contained in:
Misha Koshelev 2007-08-13 00:24:57 -05:00 committed by Alexandre Julliard
parent 70edf2d223
commit 4f405b228d
1 changed files with 7 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
dlls/urlmon/http.c
View File

@ -661,20 +661,22 @@ static HRESULT WINAPI HttpProtocol_Continue(IInternetProtocol *iface, PROTOCOLDA
if (pProtocolData->pData >= (LPVOID)BINDSTATUS_DOWNLOADINGDATA) if (pProtocolData->pData >= (LPVOID)BINDSTATUS_DOWNLOADINGDATA)
{ {
/* InternetQueryDataAvailable may immediately fork and perform its asynchronous
* read, so clear the flag _before_ calling so it does not incorrectly get cleared
* after the status callback is called */
This->flags &= ~FLAG_REQUEST_COMPLETE;
if (!InternetQueryDataAvailable(This->request, &This->available_bytes, 0, 0)) if (!InternetQueryDataAvailable(This->request, &This->available_bytes, 0, 0))
{ {
if (GetLastError() == ERROR_IO_PENDING) if (GetLastError() != ERROR_IO_PENDING)
{
This->flags &= ~FLAG_REQUEST_COMPLETE;
}
else
{ {
This->flags |= FLAG_REQUEST_COMPLETE;
WARN("InternetQueryDataAvailable failed: %d\n", GetLastError()); WARN("InternetQueryDataAvailable failed: %d\n", GetLastError());
HTTPPROTOCOL_ReportResult(This, INET_E_DATA_NOT_AVAILABLE); HTTPPROTOCOL_ReportResult(This, INET_E_DATA_NOT_AVAILABLE);
} }
} }
else else
{ {
This->flags |= FLAG_REQUEST_COMPLETE;
HTTPPROTOCOL_ReportData(This); HTTPPROTOCOL_ReportData(This);
} }
} }