From 4af8e5f24d8e4cc214b5f68dc770c6e3fc444b9b Mon Sep 17 00:00:00 2001 From: Paul Vriens Date: Tue, 27 Oct 2009 10:37:07 +0100 Subject: [PATCH] advapi32/tests: Add a input parameter check (CloseEventLog). --- dlls/advapi32/eventlog.c | 11 +++++++++-- dlls/advapi32/tests/eventlog.c | 3 --- 2 files changed, 9 insertions(+), 5 deletions(-) diff --git a/dlls/advapi32/eventlog.c b/dlls/advapi32/eventlog.c index 495623c7160..1074ccc8319 100644 --- a/dlls/advapi32/eventlog.c +++ b/dlls/advapi32/eventlog.c @@ -125,8 +125,15 @@ BOOL WINAPI ClearEventLogW( HANDLE hEventLog, LPCWSTR lpBackupFileName ) */ BOOL WINAPI CloseEventLog( HANDLE hEventLog ) { - FIXME("(%p) stub\n", hEventLog); - return TRUE; + FIXME("(%p) stub\n", hEventLog); + + if (!hEventLog) + { + SetLastError(ERROR_INVALID_HANDLE); + return FALSE; + } + + return TRUE; } /****************************************************************************** diff --git a/dlls/advapi32/tests/eventlog.c b/dlls/advapi32/tests/eventlog.c index 9fdf745fd69..2823f179e29 100644 --- a/dlls/advapi32/tests/eventlog.c +++ b/dlls/advapi32/tests/eventlog.c @@ -34,13 +34,10 @@ static void test_open_close(void) SetLastError(0xdeadbeef); ret = CloseEventLog(NULL); - todo_wine - { ok(!ret, "Expected failure\n"); ok(GetLastError() == ERROR_INVALID_HANDLE || GetLastError() == ERROR_NOACCESS, /* W2K */ "Expected ERROR_INVALID_HANDLE, got %d\n", GetLastError()); - } SetLastError(0xdeadbeef); handle = OpenEventLogA(NULL, NULL);