ReceiveTempSMS
/
Sweden-Number
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

winegstreamer: Unref the GstCaps object in init_new_decoded_pad(). 

Signed-off-by: Akihiro Sagawa <sagawa.aki@gmail.com>
Signed-off-by: Zebediah Figura <z.figura12@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
This commit is contained in:
Akihiro Sagawa 2020-05-12 22:34:09 +09:00 committed by Alexandre Julliard
parent 32be179a96
commit 49c33c920e
1 changed files with 9 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
dlls/winegstreamer/gstdemux.c
View File

@ -1003,7 +1003,7 @@ static void init_new_decoded_pad(GstElement *bin, GstPad *pad, struct gstdemux *
if (!(pin = create_pin(This, nameW))) if (!(pin = create_pin(This, nameW)))
{ {
ERR("Failed to allocate memory.\n"); ERR("Failed to allocate memory.\n");
return; goto out;
} }
if (!strcmp(typename, "video/x-raw")) if (!strcmp(typename, "video/x-raw"))
@ -1017,7 +1017,7 @@ static void init_new_decoded_pad(GstElement *bin, GstPad *pad, struct gstdemux *
{ {
ERR("Failed to create videoconvert, are %u-bit GStreamer \"base\" plugins installed?\n", ERR("Failed to create videoconvert, are %u-bit GStreamer \"base\" plugins installed?\n",
8 * (int)sizeof(void *)); 8 * (int)sizeof(void *));
return; goto out;
} }
/* GStreamer outputs RGB video top-down, but DirectShow expects bottom-up. */ /* GStreamer outputs RGB video top-down, but DirectShow expects bottom-up. */
@ -1025,7 +1025,7 @@ static void init_new_decoded_pad(GstElement *bin, GstPad *pad, struct gstdemux *
{ {
ERR("Failed to create videoflip, are %u-bit GStreamer \"good\" plugins installed?\n", ERR("Failed to create videoflip, are %u-bit GStreamer \"good\" plugins installed?\n",
8 * (int)sizeof(void *)); 8 * (int)sizeof(void *));
return; goto out;
} }
gst_bin_add(GST_BIN(This->container), vconv); /* bin takes ownership */ gst_bin_add(GST_BIN(This->container), vconv); /* bin takes ownership */
@ -1051,7 +1051,7 @@ static void init_new_decoded_pad(GstElement *bin, GstPad *pad, struct gstdemux *
{ {
ERR("Failed to create audioconvert, are %u-bit GStreamer \"base\" plugins installed?\n", ERR("Failed to create audioconvert, are %u-bit GStreamer \"base\" plugins installed?\n",
8 * (int)sizeof(void *)); 8 * (int)sizeof(void *));
return; goto out;
} }
gst_bin_add(GST_BIN(This->container), convert); gst_bin_add(GST_BIN(This->container), convert);
@ -1069,7 +1069,7 @@ static void init_new_decoded_pad(GstElement *bin, GstPad *pad, struct gstdemux *
gst_pad_link_get_name(ret)); gst_pad_link_get_name(ret));
gst_object_unref(pin->post_sink); gst_object_unref(pin->post_sink);
pin->post_sink = NULL; pin->post_sink = NULL;
return; goto out;
} }
if ((ret = gst_pad_link(pin->post_src, pin->my_sink)) < 0) if ((ret = gst_pad_link(pin->post_src, pin->my_sink)) < 0)
@ -1080,18 +1080,20 @@ static void init_new_decoded_pad(GstElement *bin, GstPad *pad, struct gstdemux *
pin->post_src = NULL; pin->post_src = NULL;
gst_object_unref(pin->post_sink); gst_object_unref(pin->post_sink);
pin->post_sink = NULL; pin->post_sink = NULL;
return; goto out;
} }
} }
else if ((ret = gst_pad_link(pad, pin->my_sink)) < 0) else if ((ret = gst_pad_link(pad, pin->my_sink)) < 0)
{ {
ERR("Failed to link decodebin source pad to our sink pad, error %s.\n", ERR("Failed to link decodebin source pad to our sink pad, error %s.\n",
gst_pad_link_get_name(ret)); gst_pad_link_get_name(ret));
return; goto out;
} }
gst_pad_set_active(pin->my_sink, 1); gst_pad_set_active(pin->my_sink, 1);
gst_object_ref(pin->their_src = pad); gst_object_ref(pin->their_src = pad);
out:
gst_caps_unref(caps);
} }
static void existing_new_pad(GstElement *bin, GstPad *pad, gpointer user) static void existing_new_pad(GstElement *bin, GstPad *pad, gpointer user)