From 4907f2626c56d42f6e8c98832e4f801e06ba3c2d Mon Sep 17 00:00:00 2001 From: Paul Gofman Date: Thu, 7 Nov 2019 13:44:35 +0300 Subject: [PATCH] kernel32: Output a message in GetVolumeInformationW() when device has no read access. A lot of applications fail to install from CDs or mounted ISO images when Wine does not return correct volume label from GetVolumeInformation() repeatedly asking to insert correct disk. Most of the time it happens because the block device is read only for user (which is typical default behaviour) and FS info cannot be read. It looks like the hint about what went wrong will simplify things in this common case. Signed-off-by: Paul Gofman Signed-off-by: Alexandre Julliard --- dlls/kernel32/volume.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/dlls/kernel32/volume.c b/dlls/kernel32/volume.c index 2c8a668b730..02d14cdcc9d 100644 --- a/dlls/kernel32/volume.c +++ b/dlls/kernel32/volume.c @@ -772,8 +772,12 @@ BOOL WINAPI GetVolumeInformationW( LPCWSTR root, LPWSTR label, DWORD label_len, CloseHandle( handle ); goto fill_fs_info; } - else TRACE( "cannot open device %s: %x\n", debugstr_w(nt_name.Buffer), status ); - + else + { + TRACE( "cannot open device %s: %x\n", debugstr_w(nt_name.Buffer), status ); + if (status == STATUS_ACCESS_DENIED) + MESSAGE( "wine: Read access denied for device %s, FS volume label and serial are not available.\n", debugstr_w(nt_name.Buffer) ); + } /* we couldn't open the device, fallback to default strategy */ if (!set_ntstatus( NtOpenFile( &handle, SYNCHRONIZE, &attr, &io, 0,