From 4661c8d45b8f4b4b2adfb157bb16ce3466bc00f0 Mon Sep 17 00:00:00 2001 From: Zebediah Figura Date: Thu, 16 Jan 2020 10:26:10 -0600 Subject: [PATCH] msi/tests: Fix a crash on Windows 10. Signed-off-by: Zebediah Figura Signed-off-by: Hans Leidekker Signed-off-by: Alexandre Julliard --- dlls/msi/tests/install.c | 15 +++++++-------- 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/dlls/msi/tests/install.c b/dlls/msi/tests/install.c index 0bd82a621fc..f7fd83cfc08 100644 --- a/dlls/msi/tests/install.c +++ b/dlls/msi/tests/install.c @@ -2744,15 +2744,14 @@ static void test_MsiInstallProduct(void) MsiSetInternalUI(INSTALLUILEVEL_NONE, NULL); - /* szPackagePath is NULL */ - r = MsiInstallProductA(NULL, "INSTALL=ALL"); - ok(r == ERROR_INVALID_PARAMETER, - "Expected ERROR_INVALID_PARAMETER, got %d\n", r); + if (0) /* crashes on Win10 1709 */ + { + r = MsiInstallProductA(NULL, "INSTALL=ALL"); + ok(r == ERROR_INVALID_PARAMETER, "got %u\n", r); - /* both szPackagePath and szCommandLine are NULL */ - r = MsiInstallProductA(NULL, NULL); - ok(r == ERROR_INVALID_PARAMETER, - "Expected ERROR_INVALID_PARAMETER, got %d\n", r); + r = MsiInstallProductA(NULL, NULL); + ok(r == ERROR_INVALID_PARAMETER, "got %u\n", r); + } /* szPackagePath is empty */ r = MsiInstallProductA("", "INSTALL=ALL");