From 3fe9aa205495fe05f631d62b32715483cb296e1c Mon Sep 17 00:00:00 2001 From: Alexandre Julliard Date: Mon, 14 Mar 2005 17:20:58 +0000 Subject: [PATCH] Avoid accessing an uninitialized string in the failure case. --- dlls/advapi32/tests/security.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/dlls/advapi32/tests/security.c b/dlls/advapi32/tests/security.c index c3fd89cdf15..7ec288c3576 100644 --- a/dlls/advapi32/tests/security.c +++ b/dlls/advapi32/tests/security.c @@ -109,10 +109,12 @@ void test_sid() ok( r, "failed to allocate sid\n" ); r = pConvertSidToStringSidA( psid, &str ); ok( r, "failed to convert sid\n" ); - ok( !strcmp( str, refs[i].refStr ), - "incorrect sid, expected %s, got %s\n", refs[i].refStr, str ); - if( str ) + if (r) + { + ok( !strcmp( str, refs[i].refStr ), + "incorrect sid, expected %s, got %s\n", refs[i].refStr, str ); LocalFree( str ); + } if( psid ) FreeSid( psid );