From 3889dadcca1c5a0638168a3750cf566bb9d26543 Mon Sep 17 00:00:00 2001 From: Nikolay Sivov Date: Sun, 7 Jun 2015 23:26:50 +0300 Subject: [PATCH] riched20: Handle range method failures in IsEqual (Coverity). --- dlls/riched20/richole.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/dlls/riched20/richole.c b/dlls/riched20/richole.c index b7f0298c10f..198061da853 100644 --- a/dlls/riched20/richole.c +++ b/dlls/riched20/richole.c @@ -2048,10 +2048,11 @@ static HRESULT textrange_isequal(LONG start, LONG end, ITextRange *range, LONG * if (!ret) ret = &v; - ITextRange_GetStart(range, &from); - ITextRange_GetEnd(range, &to); - - *ret = (start == from && end == to) ? tomTrue : tomFalse; + if (FAILED(ITextRange_GetStart(range, &from)) || FAILED(ITextRange_GetEnd(range, &to))) { + *ret = tomFalse; + } + else + *ret = (start == from && end == to) ? tomTrue : tomFalse; return *ret == tomTrue ? S_OK : S_FALSE; }