ReceiveTempSMS
/
Sweden-Number
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

oledb32: Fix IDBInitialize instance leak on error path (Valgrind).

This commit is contained in:
Nikolay Sivov 2014-05-04 20:34:09 +04:00 committed by Alexandre Julliard
parent c7f1262613
commit 3804423f8c
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
dlls/oledb32/datainit.c
View File

@ -205,7 +205,7 @@ static const IDBInitializeVtbl dbinit_vtbl =
dbinit_Uninitialize
};
static HRESULT create_db_init(void **obj)
static HRESULT create_db_init(IUnknown **obj)
{
dbinit *This;
@ -220,7 +220,7 @@ static HRESULT create_db_init(void **obj)
This->IDBProperties_iface.lpVtbl = &dbprops_vtbl;
This->ref = 1;
*obj = &This->IDBInitialize_iface;
*obj = (IUnknown*)&This->IDBInitialize_iface;
return S_OK;
}
@ -512,7 +512,7 @@ static HRESULT WINAPI datainit_GetDataSource(IDataInitialize *iface, IUnknown *o
hr = CoCreateInstance(&provclsid, outer, clsctx, riid, (void**)datasource);
if (FAILED(hr) && IsEqualIID(riid, &IID_IDBInitialize))
hr = create_db_init((void**)datasource);
hr = create_db_init(datasource);
}
/* now set properties */
@ -555,7 +555,7 @@ static HRESULT WINAPI datainit_GetDataSource(IDataInitialize *iface, IUnknown *o
hr = set_dbpropset(name, value, &propset);
SysFreeString(name);
SysFreeString(value);
if (FAILED(hr)) return hr;
if (FAILED(hr)) break;
hr = IDBProperties_SetProperties(dbprops, 1, propset);
free_dbpropset(1, propset);