ReceiveTempSMS
/
Sweden-Number
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

quartz/dsoundrender: Don't drop stream_cs in DSoundRender_HandleEndOfStream(). 

We don't grab stream_cs to change any variables checked here, except to reset
flush_event, and that cannot result in a deadlock.

The only possible deadlocks here are:

(1) between this function and Receive(), which is correct, as the two
    should presumably be serialized;

(2) between this function and EndFlush(); however, in that case we expect
    BeginFlush() first, which will unblock the streaming thread.

Signed-off-by: Zebediah Figura <z.figura12@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
This commit is contained in:
Zebediah Figura 2020-11-30 23:51:33 -06:00 committed by Alexandre Julliard
parent 3933ceca58
commit 2d6043eb4f
1 changed files with 0 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
dlls/quartz/dsoundrender.c
View File

@ -236,9 +236,7 @@ static HRESULT DSoundRender_HandleEndOfStream(struct dsound_render *This)
if (pos1 == pos2) if (pos1 == pos2)
break; break;
LeaveCriticalSection(&This->stream_cs);
WaitForSingleObject(This->flush_event, 10); WaitForSingleObject(This->flush_event, 10);
EnterCriticalSection(&This->stream_cs);
} }
return S_OK; return S_OK;