From 2d309da2c057d630c51860b891318877e6646f50 Mon Sep 17 00:00:00 2001
From: Eric Pouech <eric.pouech@wanadoo.fr>
Date: Tue, 4 Mar 2003 02:18:20 +0000
Subject: [PATCH] Added support for Ctrl-C handling if not running in a
 console. Added (maintenance) configuration var to trigger external debugger
 on winedbg's exceptions.

---
 programs/winedbg/dbg.y      | 62 ++++++++++++++++++++++---------------
 programs/winedbg/debugger.h |  1 +
 programs/winedbg/intvar.h   |  1 +
 programs/winedbg/winedbg.c  | 15 ++++++---
 4 files changed, 49 insertions(+), 30 deletions(-)

diff --git a/programs/winedbg/dbg.y b/programs/winedbg/dbg.y
index 75e439b62d3..a8daadce5be 100644
--- a/programs/winedbg/dbg.y
+++ b/programs/winedbg/dbg.y
@@ -386,32 +386,44 @@ void DEBUG_Exit(DWORD ec)
 
 static WINE_EXCEPTION_FILTER(wine_dbg_cmd)
 {
-   DEBUG_Printf(DBG_CHN_MESG, "\nwine_dbg_cmd: ");
-   switch (GetExceptionCode()) {
-   case DEBUG_STATUS_INTERNAL_ERROR:
-      DEBUG_Printf(DBG_CHN_MESG, "WineDbg internal error\n");
-      break;
-   case DEBUG_STATUS_NO_SYMBOL:
-      DEBUG_Printf(DBG_CHN_MESG, "Undefined symbol\n");
-      break;
-   case DEBUG_STATUS_DIV_BY_ZERO:
-      DEBUG_Printf(DBG_CHN_MESG, "Division by zero\n");
-      break;
-   case DEBUG_STATUS_BAD_TYPE:
-      DEBUG_Printf(DBG_CHN_MESG, "No type or type mismatch\n");
-      break;
-   case DEBUG_STATUS_NO_FIELD:
-      DEBUG_Printf(DBG_CHN_MESG, "No such field in structure or union\n");
-      break;
-   case DEBUG_STATUS_ABORT:
-       break;
-   default:
-      DEBUG_Printf(DBG_CHN_MESG, "Exception %lx\n", GetExceptionCode());
-      DEBUG_ExternalDebugger();
-      break;
-   }
+    if (DBG_IVAR(ExtDbgOnInternalException))
+        DEBUG_ExternalDebugger();
+    DEBUG_Printf(DBG_CHN_MESG, "\nwine_dbg_cmd: ");
+    switch (GetExceptionCode()) {
+    case DEBUG_STATUS_INTERNAL_ERROR:
+        DEBUG_Printf(DBG_CHN_MESG, "WineDbg internal error\n");
+        if (DBG_IVAR(ExtDbgOnInternalException))
+            DEBUG_ExternalDebugger();
+        break;
+    case DEBUG_STATUS_NO_SYMBOL:
+        DEBUG_Printf(DBG_CHN_MESG, "Undefined symbol\n");
+        break;
+    case DEBUG_STATUS_DIV_BY_ZERO:
+        DEBUG_Printf(DBG_CHN_MESG, "Division by zero\n");
+        break;
+    case DEBUG_STATUS_BAD_TYPE:
+        DEBUG_Printf(DBG_CHN_MESG, "No type or type mismatch\n");
+        break;
+    case DEBUG_STATUS_NO_FIELD:
+        DEBUG_Printf(DBG_CHN_MESG, "No such field in structure or union\n");
+        break;
+    case DEBUG_STATUS_ABORT:
+        break;
+    case CONTROL_C_EXIT:
+        /* this is generally sent by a ctrl-c when we run winedbg outside of wineconsole */
+        DEBUG_Printf(DBG_CHN_MESG, "Ctrl-C\n");
+        /* stop the debuggee, and continue debugger execution, we will be reintered by the
+         * debug events generated by stopping
+         */
+        DEBUG_InterruptDebuggee();
+        return EXCEPTION_CONTINUE_EXECUTION;
+    default:
+        DEBUG_Printf(DBG_CHN_MESG, "Exception %lx\n", GetExceptionCode());
+        DEBUG_ExternalDebugger();
+        break;
+    }
 
-   return EXCEPTION_EXECUTE_HANDLER;
+    return EXCEPTION_EXECUTE_HANDLER;
 }
 
 static  void set_default_channels(void)
diff --git a/programs/winedbg/debugger.h b/programs/winedbg/debugger.h
index 9eb52084ed2..7ab9479c8c8 100644
--- a/programs/winedbg/debugger.h
+++ b/programs/winedbg/debugger.h
@@ -543,6 +543,7 @@ extern void             DEBUG_DelThread(DBG_THREAD* t);
 extern BOOL             DEBUG_ProcessGetString(char* buffer, int size, HANDLE hp, LPSTR addr);
 extern BOOL             DEBUG_ProcessGetStringIndirect(char* buffer, int size, HANDLE hp, LPVOID addr);
 extern void             DEBUG_WaitNextException(DWORD cont, int count, int mode);
+extern BOOL             DEBUG_InterruptDebuggee(void);
 extern int curr_frame;
 
 /* gdbproxy.c */
diff --git a/programs/winedbg/intvar.h b/programs/winedbg/intvar.h
index 370e939c620..839879d39da 100644
--- a/programs/winedbg/intvar.h
+++ b/programs/winedbg/intvar.h
@@ -33,6 +33,7 @@ INTERNAL_VAR(StdChannelMask,		0,		NULL,  			DT_BASIC_CONST_INT)
 
    /* debugging debugger */
 INTERNAL_VAR(ExtDbgOnInvalidAddress,	FALSE,		NULL,  			DT_BASIC_CONST_INT)
+INTERNAL_VAR(ExtDbgOnInternalException, FALSE,          NULL,                   DT_BASIC_CONST_INT)
 
    /* current process/thread */
 INTERNAL_VAR(ThreadId,			FALSE,		&DEBUG_CurrTid,		DT_BASIC_CONST_INT)
diff --git a/programs/winedbg/winedbg.c b/programs/winedbg/winedbg.c
index 0297f2efada..5e63de4a6e1 100644
--- a/programs/winedbg/winedbg.c
+++ b/programs/winedbg/winedbg.c
@@ -988,15 +988,20 @@ void	DEBUG_Run(const char* args)
     }
 }
 
+BOOL DEBUG_InterruptDebuggee(void)
+{
+    DEBUG_Printf(DBG_CHN_MESG, "Ctrl-C: stopping debuggee\n");
+    /* FIXME: since we likely have a single process, signal the first process
+     * in list
+     */
+    return DEBUG_ProcessList && DebugBreakProcess(DEBUG_ProcessList->handle);
+}
+
 static BOOL WINAPI DEBUG_CtrlCHandler(DWORD dwCtrlType)
 {
     if (dwCtrlType == CTRL_C_EVENT)
     {
-        DEBUG_Printf(DBG_CHN_MESG, "Ctrl-C: stopping debuggee\n");
-        /* FIXME: since we likely have a single process, signal the first process
-         * in list
-         */
-        return DEBUG_ProcessList && DebugBreakProcess(DEBUG_ProcessList->handle);
+        return DEBUG_InterruptDebuggee();
     }
     return FALSE;
 }