From 2a26e954ec13bc2fc47b6464ee063b102b6b4e7e Mon Sep 17 00:00:00 2001 From: Alexandre Julliard Date: Mon, 21 Jun 2010 11:49:07 +0200 Subject: [PATCH] hlink/tests: Comment out a test for an uninitialized return value. --- dlls/hlink/tests/hlink.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/dlls/hlink/tests/hlink.c b/dlls/hlink/tests/hlink.c index d454819e57c..cf031f5c9c7 100644 --- a/dlls/hlink/tests/hlink.c +++ b/dlls/hlink/tests/hlink.c @@ -1093,7 +1093,8 @@ static void test_HlinkGetSetMonikerReference(void) /* invalid HLINKSETF flags */ hres = IHlink_SetMonikerReference(hlink, 12, dummy2, two); - ok(hres == 12, "IHlink_SetMonikerReference should've failed with 0x%08x, failed with 0x%08x\n", 12, hres); + /* Windows returns garbage; on 32-bit it returns the flags probably because the compiler happened to store them in %eax at some point */ + if (0) ok(hres == 12, "IHlink_SetMonikerReference should've failed with 0x%08x, failed with 0x%08x\n", 12, hres); hres = IHlink_GetMonikerReference(hlink, HLINKGETREF_DEFAULT, &found_trgt, &found_loc); ok(found_trgt == dummy, "Found target should've been %p, was: %p\n", dummy, found_trgt); @@ -1244,10 +1245,11 @@ static void test_HlinkGetSetStringReference(void) CoTaskMemFree(fnd_loc); hres = IHlink_SetStringReference(link, 4, NULL, NULL); - ok(hres == 4, "IHlink_SetStringReference should have failed with 0x4, instead: 0x%08x\n", hres); + /* Windows returns garbage; on 32-bit it returns the flags probably because the compiler happened to store them in %eax at some point */ + if (0) ok(hres == 4, "IHlink_SetStringReference should have failed with 0x4, instead: 0x%08x\n", hres); hres = IHlink_SetStringReference(link, -4, NULL, NULL); - ok(hres == -4, "IHlink_SetStringReference should have failed with 0xFFFFFFFC, instead: 0x%08x\n", hres); + if (0) ok(hres == -4, "IHlink_SetStringReference should have failed with 0xFFFFFFFC, instead: 0x%08x\n", hres); IHlink_Release(link); }