ReceiveTempSMS/Sweden-Number
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

msi: Use fetch_int to reduce code duplication and access to table data.

Browse Source
This commit is contained in:
James Hawkins 2007-06-07 16:37:48 -07:00 committed by Alexandre Julliard
parent 7318ae2411
commit 298699e242
1 changed files with 3 additions and 26 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

29
dlls/msi/table.c
View File

@ -1565,33 +1565,10 @@ static UINT TABLE_find_matching_rows( struct tagMSIVIEW *view, UINT col,
for (i = 0; i < num_rows; i++, new_entry++) for (i = 0; i < num_rows; i++, new_entry++)
{ {
UINT row_value, n; UINT row_value;
UINT offset;
USHORT **data; if (view->ops->fetch_int( view, i, col, &row_value ) != ERROR_SUCCESS)
UINT row = i;
if( row >= tv->table->row_count )
{
row -= tv->table->row_count;
data = tv->table->nonpersistent_data;
}
else
data = tv->table->data;
n = bytes_per_column( &tv->columns[col-1] );
switch( n )
{
case 4:
offset = tv->columns[col-1].offset/2;
row_value = data[row][offset] +
(data[row][offset + 1] << 16);
break;
case 2:
offset = tv->columns[col-1].offset/2;
row_value = data[row][offset];
break;
default:
ERR("oops! what is %d bytes per column?\n", n );
continue; continue;
}
new_entry->next = NULL; new_entry->next = NULL;
new_entry->value = row_value; new_entry->value = row_value;