From 2951007d18b2337874353565e680cbc4d9f8dd65 Mon Sep 17 00:00:00 2001 From: Austin English Date: Thu, 3 Feb 2011 18:28:47 -0800 Subject: [PATCH] advapi32/tests: Make sure to use return value (LLVM/Clang). --- dlls/advapi32/tests/crypt_lmhash.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/dlls/advapi32/tests/crypt_lmhash.c b/dlls/advapi32/tests/crypt_lmhash.c index 384221f065d..a6e812e54a9 100644 --- a/dlls/advapi32/tests/crypt_lmhash.c +++ b/dlls/advapi32/tests/crypt_lmhash.c @@ -211,6 +211,7 @@ static void test_SystemFunction003(void) memset(output, 0, sizeof output); r = pSystemFunction002(data, key, output); + ok(r == STATUS_SUCCESS, "function failed\n"); ok( !memcmp(exp2, output, sizeof output), "decrypted message wrong\n"); } @@ -284,16 +285,19 @@ static void test_SystemFunction004(void) memset(output, 0, sizeof output); r = pSystemFunction002(out.Buffer, key.Buffer, output); + ok(r == STATUS_SUCCESS, "function failed\n"); ok(((unsigned int*)output)[0] == in.Length, "crypted length wrong\n"); ok(((unsigned int*)output)[1] == 1, "crypted value wrong\n"); memset(output, 0, sizeof output); r = pSystemFunction002(out.Buffer+8, key.Buffer, output); + ok(r == STATUS_SUCCESS, "function failed\n"); ok(!memcmp(output, inbuf, sizeof output), "crypted data wrong\n"); memset(output, 0, sizeof output); r = pSystemFunction002(out.Buffer+16, key.Buffer, output); + ok(r == STATUS_SUCCESS, "function failed\n"); ok(!memcmp(output, inbuf, sizeof output), "crypted data wrong\n"); } @@ -496,12 +500,6 @@ static void test_memcmpfunc(memcmpfunc fn) return; } - if (0) - { - /* crashes */ - r = fn(NULL, NULL); - } - memset(arg1, 0, sizeof arg1); memset(arg2, 0, sizeof arg2); arg1[0x10] = 1;