From 26883637141441d88c3865b42d61f67a3668a489 Mon Sep 17 00:00:00 2001 From: Nikolay Sivov Date: Sun, 7 Jun 2015 23:41:12 +0300 Subject: [PATCH] riched20: Handle range method failures in InRange (Coverity). --- dlls/riched20/richole.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/dlls/riched20/richole.c b/dlls/riched20/richole.c index 198061da853..1cb658997aa 100644 --- a/dlls/riched20/richole.c +++ b/dlls/riched20/richole.c @@ -2006,10 +2006,11 @@ static HRESULT textrange_inrange(LONG start, LONG end, ITextRange *range, LONG * if (!ret) ret = &v; - ITextRange_GetStart(range, &from); - ITextRange_GetEnd(range, &to); - - *ret = (start >= from && end <= to) ? tomTrue : tomFalse; + if (FAILED(ITextRange_GetStart(range, &from)) || FAILED(ITextRange_GetEnd(range, &to))) { + *ret = tomFalse; + } + else + *ret = (start >= from && end <= to) ? tomTrue : tomFalse; return *ret == tomTrue ? S_OK : S_FALSE; }