ReceiveTempSMS/Sweden-Number
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

kernel32: Revise SetThreadIdealProcessor to return success.

Browse Source
This commit is contained in:
Andrew Nguyen 2009-08-07 06:39:47 -05:00 committed by Alexandre Julliard
parent e306b91392
commit 20276d0b38
2 changed files with 23 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
dlls/kernel32/tests/thread.c
View File

@ -812,23 +812,25 @@ static VOID test_thread_processor(void)
"SetThreadAffinityMask passed for an illegal processor\n"); "SetThreadAffinityMask passed for an illegal processor\n");
/* NOTE: This only works on WinNT/2000/XP) */ /* NOTE: This only works on WinNT/2000/XP) */
if (pSetThreadIdealProcessor) { if (pSetThreadIdealProcessor) {
todo_wine { SetLastError(0xdeadbeef);
SetLastError(0);
error=pSetThreadIdealProcessor(curthread,0); error=pSetThreadIdealProcessor(curthread,0);
if (GetLastError()!=ERROR_CALL_NOT_IMPLEMENTED) { if (GetLastError()==ERROR_CALL_NOT_IMPLEMENTED)
{
win_skip("SetThreadIdealProcessor is not implemented\n");
return;
}
ok(error!=-1, "SetThreadIdealProcessor failed\n"); ok(error!=-1, "SetThreadIdealProcessor failed\n");
}
} SetLastError(0xdeadbeef);
if (GetLastError()!=ERROR_CALL_NOT_IMPLEMENTED) {
error=pSetThreadIdealProcessor(curthread,MAXIMUM_PROCESSORS+1); error=pSetThreadIdealProcessor(curthread,MAXIMUM_PROCESSORS+1);
ok(error==-1, ok(error==-1,
"SetThreadIdealProcessor succeeded with an illegal processor #\n"); "SetThreadIdealProcessor succeeded with an illegal processor #\n");
todo_wine { ok(GetLastError()==ERROR_INVALID_PARAMETER,
"Expected ERROR_INVALID_PARAMETER, got %d\n", GetLastError());
error=pSetThreadIdealProcessor(curthread,MAXIMUM_PROCESSORS); error=pSetThreadIdealProcessor(curthread,MAXIMUM_PROCESSORS);
ok(error==0, "SetThreadIdealProcessor returned an incorrect value\n"); ok(error==0, "SetThreadIdealProcessor returned an incorrect value\n");
} }
}
}
} }
static VOID test_GetThreadExitCode(void) static VOID test_GetThreadExitCode(void)

8
dlls/kernel32/thread.c
View File

@ -413,8 +413,12 @@ DWORD WINAPI SetThreadIdealProcessor(
DWORD dwIdealProcessor) /* [in] Specifies the new preferred processor */ DWORD dwIdealProcessor) /* [in] Specifies the new preferred processor */
{ {
FIXME("(%p): stub\n",hThread); FIXME("(%p): stub\n",hThread);
SetLastError(ERROR_CALL_NOT_IMPLEMENTED); if (dwIdealProcessor > MAXIMUM_PROCESSORS)
return -1L; {
SetLastError(ERROR_INVALID_PARAMETER);
return ~0u;
}
return 0;
} }