From 19007cf31f42fc0c329e5a6f25e504e0a1fe21ef Mon Sep 17 00:00:00 2001 From: Zebediah Figura Date: Sat, 6 Jun 2020 15:35:32 -0500 Subject: [PATCH] ntdll: Avoid leaking "drive" on error paths from get_mountmgr_fs_info() (Valgrind). Signed-off-by: Zebediah Figura Signed-off-by: Alexandre Julliard --- dlls/ntdll/file.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/dlls/ntdll/file.c b/dlls/ntdll/file.c index b5a48db176d..1b70e473676 100644 --- a/dlls/ntdll/file.c +++ b/dlls/ntdll/file.c @@ -2328,7 +2328,10 @@ static struct mountmgr_unix_drive *get_mountmgr_fs_info( HANDLE handle, int fd ) InitializeObjectAttributes( &attr, &string, 0, NULL, NULL ); if (NtOpenFile( &mountmgr, GENERIC_READ | SYNCHRONIZE, &attr, &io, FILE_SHARE_READ | FILE_SHARE_WRITE, FILE_SYNCHRONOUS_IO_NONALERT )) + { + RtlFreeHeap( GetProcessHeap(), 0, drive ); return NULL; + } status = NtDeviceIoControlFile( mountmgr, NULL, NULL, NULL, &io, IOCTL_MOUNTMGR_QUERY_UNIX_DRIVE, drive, sizeof(*drive), drive, 1024 );