From 17cfa282160ec658e8790c7c81f598e965214f28 Mon Sep 17 00:00:00 2001 From: Mike McCormack Date: Wed, 9 Feb 2005 13:22:49 +0000 Subject: [PATCH] Fix a memory leak in MsiConfigureProductExW. --- dlls/msi/msi.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/dlls/msi/msi.c b/dlls/msi/msi.c index 9f934033c5d..b0592a6ba9b 100644 --- a/dlls/msi/msi.c +++ b/dlls/msi/msi.c @@ -476,7 +476,7 @@ UINT WINAPI MsiConfigureProductExW(LPCWSTR szProduct, int iInstallLevel, * ok 1, we need to find the msi file for this product. * 2, find the source dir for the files * 3, do the configure/install. - 4, cleanupany runonce entry. + * 4, cleanupany runonce entry. */ rc = MsiOpenProductW(szProduct,&handle); @@ -485,7 +485,7 @@ UINT WINAPI MsiConfigureProductExW(LPCWSTR szProduct, int iInstallLevel, package = msihandle2msiinfo(handle, MSIHANDLETYPE_PACKAGE); - sz = strlenW(szInstalled); + sz = strlenW(szInstalled); if (szCommandLine) sz += strlenW(szCommandLine); @@ -502,6 +502,8 @@ UINT WINAPI MsiConfigureProductExW(LPCWSTR szProduct, int iInstallLevel, rc = ACTION_DoTopLevelINSTALL(package, sourcepath, commandline); + msiobj_release( &package->hdr ); + HeapFree(GetProcessHeap(),0,commandline); end: RegCloseKey(hkey);