ReceiveTempSMS
/
Sweden-Number
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

wmc: xmalloc shouldn't initialize to zero, do that explicitly where needed.

This commit is contained in:
Alexandre Julliard 2006-08-26 21:29:13 +02:00
parent 883aef172d
commit 1659f53c3a
2 changed files with 8 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
tools/wmc/mcy.y
View File

@ -389,7 +389,7 @@ lines : tLINE { $$ = $1; }
/*---------------------------------------------------------------------- /*----------------------------------------------------------------------
* Helper rules * Helper rules
*/ */
token : tIDENT { $$ = xmalloc(sizeof(token_t)); $$->name = $1; } token : tIDENT { $$ = xmalloc(sizeof(token_t)); memset($$,0,sizeof(*$$)); $$->name = $1; }
| tTOKEN { $$ = $1; } | tTOKEN { $$ = $1; }
; ;
@ -451,7 +451,10 @@ static msg_t *add_lanmsg(msg_t *msg, lanmsg_t *lanmsg)
{ {
int i; int i;
if(!msg) if(!msg)
{
msg = xmalloc(sizeof(msg_t)); msg = xmalloc(sizeof(msg_t));
memset( msg, 0, sizeof(*msg) );
}
msg->msgs = xrealloc(msg->msgs, (msg->nmsgs+1) * sizeof(*(msg->msgs))); msg->msgs = xrealloc(msg->msgs, (msg->nmsgs+1) * sizeof(*(msg->msgs)));
msg->msgs[msg->nmsgs] = lanmsg; msg->msgs[msg->nmsgs] = lanmsg;
msg->nmsgs++; msg->nmsgs++;
@ -489,7 +492,8 @@ static msg_t *complete_msg(msg_t *mp, int id)
static void add_node(node_e type, void *p) static void add_node(node_e type, void *p)
{ {
node_t *ndp = (node_t *)xmalloc(sizeof(node_t)); node_t *ndp = xmalloc(sizeof(node_t));
memset( ndp, 0, sizeof(*ndp) );
ndp->type = type; ndp->type = type;
ndp->u.all = p; ndp->u.all = p;
@ -601,7 +605,7 @@ static lan_blk_t *block_messages(node_t *head)
for(nl = 0; nl < msgtab[0]->nmsgs; nl++) /* This should be equal for all after check_languages() */ for(nl = 0; nl < msgtab[0]->nmsgs; nl++) /* This should be equal for all after check_languages() */
{ {
lbp = xmalloc(sizeof(lan_blk_t)); lbp = xmalloc(sizeof(lan_blk_t));
memset( lbp, 0, sizeof(*lbp) );
if(!lblktail) if(!lblktail)
{ {
lblkhead = lblktail = lbp; lblkhead = lblktail = lbp;

7
tools/wmc/utils.c
View File

@ -148,12 +148,7 @@ void *xmalloc(size_t size)
{ {
error("Virtual memory exhausted.\n"); error("Virtual memory exhausted.\n");
} }
/* memset(res, 0x55, size);
* We set it to 0.
* This is *paramount* because we depend on it
* just about everywhere in the rest of the code.
*/
memset(res, 0, size);
return res; return res;
} }