From 1571df572229647ef8161b4f9614da8082a18815 Mon Sep 17 00:00:00 2001 From: Robert Shearman Date: Sat, 19 Mar 2005 17:05:12 +0000 Subject: [PATCH] Fix memory leak in OleDuplicateData on error path (found by Smatch). --- dlls/ole32/ole2impl.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/dlls/ole32/ole2impl.c b/dlls/ole32/ole2impl.c index 160e0e1396c..b939623e470 100644 --- a/dlls/ole32/ole2impl.c +++ b/dlls/ole32/ole2impl.c @@ -259,9 +259,8 @@ HANDLE WINAPI OleDuplicateData(HANDLE hSrc, CLIPFORMAT cfFormat, if (!size) return NULL; bm.bmBits = HeapAlloc(GetProcessHeap(), 0, size); if (!bm.bmBits) return NULL; - if (!GetBitmapBits(hSrc, size, bm.bmBits)) - return NULL; - hDst = CreateBitmapIndirect(&bm); + if (GetBitmapBits(hSrc, size, bm.bmBits)) + hDst = CreateBitmapIndirect(&bm); HeapFree(GetProcessHeap(), 0, bm.bmBits); break; }