iphlpapi: Return error for IP address with value zero in IcmpSendEcho.

This commit is contained in:
Bruno Jesus 2014-01-09 20:45:37 -02:00 committed by Alexandre Julliard
parent 25e0f11ced
commit 1470d7b4cc
2 changed files with 5 additions and 2 deletions

View File

@ -239,6 +239,11 @@ DWORD WINAPI IcmpSendEcho(
}
/* check the request size against SO_MAX_MSG_SIZE using getsockopt */
if (!DestinationAddress) {
SetLastError(ERROR_INVALID_NETNAME);
return 0;
}
/* Prepare the request */
id=getpid() & 0xFFFF;
seq=InterlockedIncrement(&icmp_sequence) & 0xFFFF;

View File

@ -906,12 +906,10 @@ todo_wine
SetLastError(0xdeadbeef);
ret = pIcmpSendEcho(icmp, address, senddata, sizeof(senddata), NULL, replydata, replysz, 1000);
error = GetLastError();
todo_wine {
ok (!ret, "IcmpSendEcho succeeded unexpectedly\n");
ok (error == ERROR_INVALID_NETNAME
|| broken(error == IP_BAD_DESTINATION) /* <= 2003 */,
"expected 1214, got %d\n", error);
}
address = htonl(INADDR_LOOPBACK);
if (0) /* crashes in XP */