ReceiveTempSMS
/
Sweden-Number
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

mstask/tests: Ignore the compare_trigger_state() return value. 

What counts is the ok() calls that compare_trigger_state() makes. Its
return value is meaningless.

Signed-off-by: Francois Gouget <fgouget@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
This commit is contained in:
Francois Gouget 2022-05-13 19:59:18 +02:00 committed by Alexandre Julliard
parent 3a3f406028
commit 1017c188f7
1 changed files with 3 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
dlls/mstask/tests/task_trigger.c
View File

@ -35,7 +35,7 @@ static DWORD obj_refcount(void *obj_to_check)
return IUnknown_Release(obj); return IUnknown_Release(obj);
} }
static BOOL compare_trigger_state(TASK_TRIGGER found_state, static void compare_trigger_state(TASK_TRIGGER found_state,
TASK_TRIGGER expected_state) TASK_TRIGGER expected_state)
{ {
ok(found_state.cbTriggerSize == expected_state.cbTriggerSize, ok(found_state.cbTriggerSize == expected_state.cbTriggerSize,
@ -105,8 +105,6 @@ static BOOL compare_trigger_state(TASK_TRIGGER found_state,
ok(found_state.wRandomMinutesInterval == expected_state.wRandomMinutesInterval, ok(found_state.wRandomMinutesInterval == expected_state.wRandomMinutesInterval,
"wRandomMinutesInterval: Found %d but expected %d\n", "wRandomMinutesInterval: Found %d but expected %d\n",
found_state.wRandomMinutesInterval, expected_state.wRandomMinutesInterval); found_state.wRandomMinutesInterval, expected_state.wRandomMinutesInterval);
return TRUE;
} }
static void test_SetTrigger_GetTrigger(void) static void test_SetTrigger_GetTrigger(void)
@ -342,14 +340,12 @@ static void test_SetTrigger_GetTrigger(void)
trigger_state.cbTriggerSize = sizeof(trigger_state) - 1; trigger_state.cbTriggerSize = sizeof(trigger_state) - 1;
hres = ITaskTrigger_GetTrigger(test_trigger, &trigger_state); hres = ITaskTrigger_GetTrigger(test_trigger, &trigger_state);
ok(hres == S_OK, "Failed to GetTrigger\n"); ok(hres == S_OK, "Failed to GetTrigger\n");
ok(compare_trigger_state(trigger_state, normal_trigger_state), compare_trigger_state(trigger_state, normal_trigger_state);
"Invalid state\n");
memset(&trigger_state, 0xcf, sizeof(trigger_state)); memset(&trigger_state, 0xcf, sizeof(trigger_state));
trigger_state.cbTriggerSize = 0; trigger_state.cbTriggerSize = 0;
hres = ITaskTrigger_GetTrigger(test_trigger, &trigger_state); hres = ITaskTrigger_GetTrigger(test_trigger, &trigger_state);
ok(hres == S_OK, "Failed to GetTrigger\n"); ok(hres == S_OK, "Failed to GetTrigger\n");
ok(compare_trigger_state(trigger_state, normal_trigger_state), compare_trigger_state(trigger_state, normal_trigger_state);
"Invalid state\n");
ITaskTrigger_Release(test_trigger); ITaskTrigger_Release(test_trigger);
ITask_Release(test_task); ITask_Release(test_task);