ReceiveTempSMS
/
Sweden-Number
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

widl: Remove some FIXME comments and replace them with comments explaining why the current behaviour is correct.

This commit is contained in:
Rob Shearman 2010-03-15 19:30:50 +00:00 committed by Alexandre Julliard
parent 9aad144755
commit 0e6ad1fa85
1 changed files with 9 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
tools/widl/typegen.c
View File

@ -1555,8 +1555,10 @@ static void write_member_type(FILE *file, const type_t *cont,
reloff = absoff - (*tfsoff + 2); reloff = absoff - (*tfsoff + 2);
print_file(file, 2, "0x4c,\t/* FC_EMBEDDED_COMPLEX */\n"); print_file(file, 2, "0x4c,\t/* FC_EMBEDDED_COMPLEX */\n");
/* FIXME: actually compute necessary padding */ /* padding is represented using FC_STRUCTPAD* types, so presumably
print_file(file, 2, "0x0,\t/* FIXME: padding */\n"); * this is left over in the format for historical purposes in MIDL
* or rpcrt4. */
print_file(file, 2, "0x0,\n");
print_file(file, 2, "NdrFcShort(0x%hx),\t/* Offset= %hd (%u) */\n", print_file(file, 2, "NdrFcShort(0x%hx),\t/* Offset= %hd (%u) */\n",
reloff, reloff, absoff); reloff, reloff, absoff);
*tfsoff += 4; *tfsoff += 4;
@ -1651,8 +1653,11 @@ static int write_pointer_description_offsets(
{ {
unsigned int memsize; unsigned int memsize;
/* pointer instance */ /* pointer instance
/* FIXME: sometimes from end of structure, sometimes from beginning */ *
* note that MSDN states that for pointer layouts in structures,
* this is a negative offset from the end of the structure, but
* this statement is incorrect. all offsets are positive */
print_file(file, 2, "NdrFcShort(0x%hx),\t/* Memory offset = %d */\n", *offset_in_memory, *offset_in_memory); print_file(file, 2, "NdrFcShort(0x%hx),\t/* Memory offset = %d */\n", *offset_in_memory, *offset_in_memory);
print_file(file, 2, "NdrFcShort(0x%hx),\t/* Buffer offset = %d */\n", *offset_in_buffer, *offset_in_buffer); print_file(file, 2, "NdrFcShort(0x%hx),\t/* Buffer offset = %d */\n", *offset_in_buffer, *offset_in_buffer);