ReceiveTempSMS
/
Sweden-Number
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

msi: Fix leaks in ITERATE_InstallService (coverity).

This commit is contained in:
Frédéric Delanoy 2012-11-16 11:50:28 +01:00 committed by Alexandre Julliard
parent cac26d47a0
commit 098b3c7294
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
dlls/msi/action.c
View File

@ -5752,6 +5752,7 @@ static UINT ITERATE_InstallService(MSIRECORD *rec, LPVOID param)
LPWSTR depends = NULL, pass = NULL, args = NULL, image_path = NULL; LPWSTR depends = NULL, pass = NULL, args = NULL, image_path = NULL;
DWORD serv_type, start_type, err_control; DWORD serv_type, start_type, err_control;
SERVICE_DESCRIPTIONW sd = {NULL}; SERVICE_DESCRIPTIONW sd = {NULL};
UINT ret = ERROR_SUCCESS;
comp = MSI_RecordGetString( rec, 12 ); comp = MSI_RecordGetString( rec, 12 );
component = msi_get_loaded_component( package, comp ); component = msi_get_loaded_component( package, comp );
@ -5809,7 +5810,10 @@ static UINT ITERATE_InstallService(MSIRECORD *rec, LPVOID param)
{ {
int len = strlenW(file->TargetPath) + strlenW(args) + 2; int len = strlenW(file->TargetPath) + strlenW(args) + 2;
if (!(image_path = msi_alloc(len * sizeof(WCHAR)))) if (!(image_path = msi_alloc(len * sizeof(WCHAR))))
return ERROR_OUTOFMEMORY; {
ret = ERROR_OUTOFMEMORY;
goto done;
}
strcpyW(image_path, file->TargetPath); strcpyW(image_path, file->TargetPath);
strcatW(image_path, szSpace); strcatW(image_path, szSpace);
@ -5843,7 +5847,7 @@ done:
msi_free(depends); msi_free(depends);
msi_free(args); msi_free(args);
return ERROR_SUCCESS; return ret;
} }
static UINT ACTION_InstallServices( MSIPACKAGE *package ) static UINT ACTION_InstallServices( MSIPACKAGE *package )