ReceiveTempSMS
/
Sweden-Number
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

mciavi32: Remove unnecessary string buffers in MCIAVI_mciSet.

This commit is contained in:
Vincent Povirk 2009-04-14 11:56:54 -05:00 committed by Alexandre Julliard
parent 5f4cc6a89b
commit 075ff23394
1 changed files with 20 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

39
dlls/mciavi32/info.c
View File

@ -225,72 +225,73 @@ DWORD MCIAVI_mciSet(UINT wDevID, DWORD dwFlags, LPMCI_DGV_SET_PARMS lpParms)
} }
if (dwFlags & MCI_SET_ON) { if (dwFlags & MCI_SET_ON) {
char buffer[256]; const char *szVideo="";
const char *szAudio="";
strcpy(buffer, "MCI_SET_ON:"); const char *szSeek="";
if (dwFlags & MCI_SET_VIDEO) { if (dwFlags & MCI_SET_VIDEO) {
strncat(buffer, " video", sizeof(buffer)-sizeof("MCI_SET_ON:")); szVideo = " video";
wma->dwSet |= 4; wma->dwSet |= 4;
} }
if (dwFlags & MCI_SET_AUDIO) { if (dwFlags & MCI_SET_AUDIO) {
strncat(buffer, " audio", sizeof(buffer)-sizeof("MCI_SET_ON:"));
switch (lpParms->dwAudio) { switch (lpParms->dwAudio) {
case MCI_SET_AUDIO_ALL: case MCI_SET_AUDIO_ALL:
strncat(buffer, " all", sizeof(buffer)-sizeof("MCI_SET_ON:")); szAudio = " audio all";
wma->dwSet |= 3; wma->dwSet |= 3;
break; break;
case MCI_SET_AUDIO_LEFT: case MCI_SET_AUDIO_LEFT:
strncat(buffer, " left", sizeof(buffer)-sizeof("MCI_SET_ON:")); szAudio = " audio left";
wma->dwSet |= 1; wma->dwSet |= 1;
break; break;
case MCI_SET_AUDIO_RIGHT: case MCI_SET_AUDIO_RIGHT:
strncat(buffer, " right", sizeof(buffer)-sizeof("MCI_SET_ON:")); szAudio = " audio right";
wma->dwSet |= 2; wma->dwSet |= 2;
break; break;
default: default:
szAudio = " audio unknown";
WARN("Unknown audio channel %u\n", lpParms->dwAudio); WARN("Unknown audio channel %u\n", lpParms->dwAudio);
break; break;
} }
} }
if (dwFlags & MCI_DGV_SET_SEEK_EXACTLY) { if (dwFlags & MCI_DGV_SET_SEEK_EXACTLY) {
strncat(buffer, " seek_exactly", sizeof(buffer)); szSeek = " seek_exactly";
} }
FIXME("%s\n", buffer); FIXME("MCI_SET_ON:%s%s%s\n", szVideo, szAudio, szSeek);
} }
if (dwFlags & MCI_SET_OFF) { if (dwFlags & MCI_SET_OFF) {
char buffer[256]; const char *szVideo="";
const char *szAudio="";
const char *szSeek="";
strcpy(buffer, "MCI_SET_OFF:");
if (dwFlags & MCI_SET_VIDEO) { if (dwFlags & MCI_SET_VIDEO) {
strncat(buffer, " video", sizeof(buffer)-sizeof("MCI_SET_OFF:")); szVideo = " video";
wma->dwSet &= ~4; wma->dwSet &= ~4;
} }
if (dwFlags & MCI_SET_AUDIO) { if (dwFlags & MCI_SET_AUDIO) {
strncat(buffer, " audio", sizeof(buffer)-sizeof("MCI_SET_OFF:"));
switch (lpParms->dwAudio) { switch (lpParms->dwAudio) {
case MCI_SET_AUDIO_ALL: case MCI_SET_AUDIO_ALL:
strncat(buffer, " all", sizeof(buffer)-sizeof("MCI_SET_OFF:")); szAudio = " audio all";
wma->dwSet &= ~3; wma->dwSet &= ~3;
break; break;
case MCI_SET_AUDIO_LEFT: case MCI_SET_AUDIO_LEFT:
strncat(buffer, " left", sizeof(buffer)-sizeof("MCI_SET_OFF:")); szAudio = " audio left";
wma->dwSet &= ~2; wma->dwSet &= ~2;
break; break;
case MCI_SET_AUDIO_RIGHT: case MCI_SET_AUDIO_RIGHT:
strncat(buffer, " right", sizeof(buffer)-sizeof("MCI_SET_OFF:")); szAudio = " audio right";
wma->dwSet &= ~2; wma->dwSet &= ~2;
break; break;
default: default:
szAudio = " audio unknown";
WARN("Unknown audio channel %u\n", lpParms->dwAudio); WARN("Unknown audio channel %u\n", lpParms->dwAudio);
break; break;
} }
} }
if (dwFlags & MCI_DGV_SET_SEEK_EXACTLY) { if (dwFlags & MCI_DGV_SET_SEEK_EXACTLY) {
strncat(buffer, " seek_exactly", sizeof(buffer)-strlen(buffer)-1); szSeek = " seek_exactly";
} }
FIXME("%s\n", buffer); FIXME("MCI_SET_OFF:%s%s%s\n", szVideo, szAudio, szSeek);
} }
if (dwFlags & MCI_DGV_SET_FILEFORMAT) { if (dwFlags & MCI_DGV_SET_FILEFORMAT) {
LPCSTR str = "save"; LPCSTR str = "save";