ReceiveTempSMS
/
Sweden-Number
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

msi: Implement MSIMODIFY_REFRESH using msi_view_refresh_row(). 

Signed-off-by: Zebediah Figura <z.figura12@gmail.com>
Signed-off-by: Hans Leidekker <hans@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
This commit is contained in:
Zebediah Figura 2019-01-28 22:11:11 -06:00 committed by Alexandre Julliard
parent 31628cee6e
commit 0597646455
3 changed files with 15 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
dlls/msi/query.h
View File

@ -153,4 +153,6 @@ UINT msi_create_table( MSIDATABASE *db, LPCWSTR name, column_info *col_info,
UINT msi_select_update( MSIVIEW *view, MSIRECORD *rec, UINT row ) DECLSPEC_HIDDEN; UINT msi_select_update( MSIVIEW *view, MSIRECORD *rec, UINT row ) DECLSPEC_HIDDEN;
UINT msi_view_refresh_row( MSIDATABASE *db, MSIVIEW *view, UINT row, MSIRECORD *rec ) DECLSPEC_HIDDEN;
#endif /* __WINE_MSI_QUERY_H */ #endif /* __WINE_MSI_QUERY_H */

15
dlls/msi/select.c
View File

@ -276,20 +276,25 @@ UINT msi_select_update(MSIVIEW *view, MSIRECORD *rec, UINT row)
return ERROR_SUCCESS; return ERROR_SUCCESS;
} }
static UINT SELECT_modify( struct tagMSIVIEW *view, MSIMODIFY eModifyMode, static UINT SELECT_modify( struct tagMSIVIEW *view, MSIMODIFY mode,
MSIRECORD *rec, UINT row ) MSIRECORD *rec, UINT row )
{ {
MSISELECTVIEW *sv = (MSISELECTVIEW*)view; MSISELECTVIEW *sv = (MSISELECTVIEW*)view;
TRACE("%p %d %p %d\n", sv, eModifyMode, rec, row ); TRACE("view %p, mode %d, rec %p, row %u.\n", view, mode, rec, row);
if( !sv->table ) if( !sv->table )
return ERROR_FUNCTION_FAILED; return ERROR_FUNCTION_FAILED;
if (eModifyMode == MSIMODIFY_UPDATE) switch (mode)
{
case MSIMODIFY_REFRESH:
return msi_view_refresh_row(sv->db, view, row, rec);
case MSIMODIFY_UPDATE:
return msi_select_update(view, rec, row); return msi_select_update(view, rec, row);
default:
return sv->table->ops->modify( sv->table, eModifyMode, rec, row ); return sv->table->ops->modify( sv->table, mode, rec, row );
}
} }
static UINT SELECT_delete( struct tagMSIVIEW *view ) static UINT SELECT_delete( struct tagMSIVIEW *view )

4
dlls/msi/tests/db.c
View File

@ -3618,6 +3618,7 @@ static void test_join(void)
r = MsiViewFetch(hview, &hrec); r = MsiViewFetch(hview, &hrec);
ok( r == ERROR_SUCCESS, "failed to fetch view: %d\n", r ); ok( r == ERROR_SUCCESS, "failed to fetch view: %d\n", r );
check_record(hrec, 2, "alveolar", "procerus");
r = MsiRecordSetStringA( hrec, 1, "epicranius" ); r = MsiRecordSetStringA( hrec, 1, "epicranius" );
ok( r == ERROR_SUCCESS, "failed to set string: %d\n", r ); ok( r == ERROR_SUCCESS, "failed to set string: %d\n", r );
@ -3627,7 +3628,8 @@ static void test_join(void)
/* try another valid operation for joins */ /* try another valid operation for joins */
r = MsiViewModify(hview, MSIMODIFY_REFRESH, hrec); r = MsiViewModify(hview, MSIMODIFY_REFRESH, hrec);
todo_wine ok( r == ERROR_SUCCESS, "failed to refresh row: %d\n", r ); ok( r == ERROR_SUCCESS, "failed to refresh row: %d\n", r );
check_record(hrec, 2, "epicranius", "procerus");
/* try an invalid operation for joins */ /* try an invalid operation for joins */
r = MsiViewModify(hview, MSIMODIFY_DELETE, hrec); r = MsiViewModify(hview, MSIMODIFY_DELETE, hrec);