Formatting.

This commit is contained in:
Werner Lemberg 2005-09-28 07:34:45 +00:00
parent d6e8b3315c
commit 7c25946f08
22 changed files with 216 additions and 185 deletions

View File

@ -5,31 +5,35 @@
2005-09-26 David Turner <david@freetype.org>
* src/autofit/aflatin.c (af_latin_compute_stem_width): fixed bad
computation of the "vertical" flag, causing ugly things in LCD mode
* src/autofit/aflatin.c (af_latin_compute_stem_width): Fix bad
computation of the `vertical' flag, causing ugly things in LCD mode
and others.
2005-09-23 David Turner <david@freetype.org>
* src/autofit/aflatin.c (af_latin_hints_init): fixed a bug that
prevented internal hint mode bitflags from being computed correctly
* src/autofit/aflatin.c (af_latin_hints_init): Fix a bug that
prevented internal hint mode bitflags from being computed correctly.
* src/base/Jamfile: adding src/base/ftgxval.c
* src/base/Jamfile: Adding src/base/ftgxval.c.
* src/gxvalid/gxvbsln.c, src/gxvalid/gxvcommn.c, src/gxvalid/gxvfeat.c,
src/gxvalid/gxvjust.c, src/gxvalid/gxvkern.c, src/gxvalid/gxvlcar.c,
src/gxvalid/gxvmort.c, src/gxvalid/gxvmort0.c, src/gxvalid/gxvmort1.c,
src/gxvalid/gxvmort2.c, src/gxvalid/gxvmort4.c, src/gxvalid/gxvmort5.c,
src/gxvalid/gxvmorx.c, src/gxvalid/gxvmorx0.c, src/gxvalid/gxvmorx1.c,
src/gxvalid/gxvmorx2.c, src/gxvalid/gxvmorx5.c, src/gxvalid/gxvopbd.c,
src/gxvalid/gxvprop.c, src/sfnt/sfdriver.c, src/truetype/ttgload.c:
removing _many_ compiler warnings when compiling with Visual C++
at maximum level (/W4)
* src/gxvalid/gxvbsln.c, src/gxvalid/gxvcommn.c,
src/gxvalid/gxvfeat.c, src/gxvalid/gxvjust.c, src/gxvalid/gxvkern.c,
src/gxvalid/gxvlcar.c, src/gxvalid/gxvmort.c,
src/gxvalid/gxvmort0.c, src/gxvalid/gxvmort1.c,
src/gxvalid/gxvmort2.c, src/gxvalid/gxvmort4.c,
src/gxvalid/gxvmort5.c, src/gxvalid/gxvmorx.c,
src/gxvalid/gxvmorx0.c, src/gxvalid/gxvmorx1.c,
src/gxvalid/gxvmorx2.c, src/gxvalid/gxvmorx5.c,
src/gxvalid/gxvopbd.c, src/gxvalid/gxvprop.c,
src/truetype/ttgload.c: Remove _many_ compiler warnings when
compiling with Visual C++ at maximum level (/W4).
* src/autofit/afangles.c (af_angle_atan): replaced CORDIC-based
* src/autofit/afangles.c (af_angle_atan): Replaced CORDIC-based
implementation with one using lookup tables. This simple thing
speeds glyph loading by 18% according to ftbench !
speeds up glyph loading by 18%, according to ftbench!
* src/sfnt/sfdriver.c (sfnt_get_interface): Don't check for
`get_sfnt' and `load_sfnt' module interfaces.
2005-09-22 Werner Lemberg <wl@gnu.org>

View File

@ -125,6 +125,7 @@
#else /* 0 */
/*
* a python script used to generate the following table
*
@ -323,6 +324,7 @@ for n in r:
#endif /* 0 */
FT_LOCAL_DEF( AF_Angle )
af_angle_diff( AF_Angle angle1,
AF_Angle angle2 )

View File

@ -132,7 +132,8 @@
GXV_LookupValueDesc value;
/* XXX: check range ? */
offset = (FT_UShort)(base_value.u + ( relative_gindex * sizeof ( FT_UShort ) ));
offset = (FT_UShort)( base_value.u +
( relative_gindex * sizeof ( FT_UShort ) ) );
p = valid->lookuptbl_head + offset;
limit = lookuptbl_limit;

View File

@ -1036,14 +1036,14 @@
FT_Byte clazz;
FT_Byte entry;
FT_UNUSED( stateSize ); /* for the non-debugging case */
GXV_NAME_ENTER( "StateArray" );
GXV_TRACE(( "parse %d bytes by stateSize=%d maxClassID=%d\n",
(int)(*length_p), stateSize, (int)(maxClassID) ));
FT_UNUSED( stateSize );
/*
* 2 states are predefined and must be described in StateArray:
* state 0 (start of text), 1 (start of line)
@ -1144,7 +1144,7 @@
switch ( GXV_GLYPHOFFSET_FMT( statetable ) )
{
case GXV_GLYPHOFFSET_NONE:
glyphOffset.uc = 0; /* make compiler happy !! */
glyphOffset.uc = 0; /* make compiler happy */
break;
case GXV_GLYPHOFFSET_UCHAR:
@ -1174,7 +1174,6 @@
default:
if ( valid->root->level >= FT_VALIDATE_PARANOID )
FT_INVALID_FORMAT;
goto Exit;
}
@ -1186,6 +1185,7 @@
statetable_limit,
valid );
}
Exit:
*length_p = (FT_UShort)( p - table );
@ -1401,7 +1401,8 @@
GXV_LookupValueDesc value;
/* XXX: check range? */
offset = (FT_UShort)(base_value.u + relative_gindex * sizeof ( FT_UShort ));
offset = (FT_UShort)( base_value.u +
relative_gindex * sizeof ( FT_UShort ) );
p = valid->lookuptbl_head + offset;
limit = lookuptbl_limit;
@ -1427,14 +1428,14 @@
FT_UShort clazz;
FT_UShort entry;
FT_UNUSED( stateSize ); /* for the non-debugging case */
GXV_NAME_ENTER( "XStateArray" );
GXV_TRACE(( "parse % 3d bytes by stateSize=% 3d maxClassID=% 3d\n",
(int)(*length_p), stateSize, (int)(maxClassID) ));
FT_UNUSED( stateSize );
/*
* 2 states are predefined and must be described:
* state 0 (start of text), 1 (start of line)

View File

@ -512,6 +512,8 @@
FT_Bool kernCrossStream;
FT_Bool kernVariation;
FT_UNUSED( valid );
/* reserved bits = 0 */
if ( coverage & 0x1FFC )
@ -520,6 +522,7 @@
kernVertical = FT_BOOL( ( coverage >> 15 ) & 1 );
kernCrossStream = FT_BOOL( ( coverage >> 14 ) & 1 );
kernVariation = FT_BOOL( ( coverage >> 13 ) & 1 );
*format = (FT_UShort)( coverage & 0x0003 );
GXV_TRACE(( "new Apple-dialect: "
@ -528,8 +531,6 @@
GXV_TRACE(( "kerning values in Apple format subtable are ignored\n" ));
FT_UNUSED( valid );
return 1;
}
@ -554,6 +555,7 @@
horizontal = FT_BOOL( ( coverage >> 15 ) & 1 );
cross_stream = FT_BOOL( ( coverage >> 13 ) & 1 );
*format = (FT_UShort)( coverage & 0x0003 );
GXV_TRACE(( "classic Apple-dialect: "
@ -583,6 +585,7 @@
FT_UNUSED( valid );
/* reserved bits = 0 */
if ( coverage & 0xFDF0 )
return 0;
@ -591,6 +594,7 @@
minimum = FT_BOOL( ( coverage >> 1 ) & 1 );
cross_stream = FT_BOOL( ( coverage >> 2 ) & 1 );
override = FT_BOOL( ( coverage >> 3 ) & 1 );
*format = (FT_UShort)( ( coverage >> 8 ) & 0x0003 );
GXV_TRACE(( "classic Microsoft-dialect: "

View File

@ -158,7 +158,8 @@
FT_UNUSED( lookuptbl_limit );
/* XXX: check range? */
offset = (FT_UShort)(base_value.u + relative_gindex * sizeof ( FT_UShort ));
offset = (FT_UShort)( base_value.u +
relative_gindex * sizeof ( FT_UShort ) );
p = valid->root->base + offset;
limit = valid->root->limit;

View File

@ -79,16 +79,17 @@
FT_UNUSED( table );
FT_UNUSED( limit );
FT_UNUSED( GXV_Mort_IndicScript_Msg[verb] ); /* for the non-debugging */
FT_UNUSED( glyphOffset ); /* case */
markFirst = (FT_UShort)( ( flags >> 15 ) & 1 );
dontAdvance = (FT_UShort)( ( flags >> 14 ) & 1 );
markLast = (FT_UShort)( ( flags >> 13 ) & 1 );
reserved = (FT_UShort)( flags & 0x1FF0 );
verb = (FT_UShort)( flags & 0x000F );
FT_UNUSED( GXV_Mort_IndicScript_Msg[verb] );
FT_UNUSED( glyphOffset );
GXV_TRACE(( " IndicScript MorphRule for glyphOffset 0x%04x",
glyphOffset.u ));
GXV_TRACE(( " markFirst=%01d", markFirst ));
@ -97,8 +98,6 @@
GXV_TRACE(( " %02d", verb ));
GXV_TRACE(( " %s\n", GXV_Mort_IndicScript_Msg[verb] ));
if ( 0 < reserved )
{
GXV_TRACE(( " non-zero bits found in reserved range\n" ));

View File

@ -113,15 +113,18 @@
FT_UNUSED( state );
substTable = ((GXV_mort_subtable_type1_StateOptRec *)
substTable =
((GXV_mort_subtable_type1_StateOptRec *)
(valid->statetable.optdata))->substitutionTable;
substTable_limit = (FT_UShort)(substTable +
substTable_limit =
(FT_UShort)( substTable +
((GXV_mort_subtable_type1_StateOptRec *)
(valid->statetable.optdata))->substitutionTable_length );
min_gid = (FT_UShort)( ( substTable - wordOffset * 2 ) / 2 );
max_gid = (FT_UShort)( ( substTable_limit - wordOffset * 2 ) / 2 );
max_gid = (FT_UShort)( FT_MAX( max_gid, valid->face->num_glyphs ) );
/* XXX: check range? */
/* TODO: min_gid & max_gid comparison with ClassTable contents */
@ -150,6 +153,7 @@
setMark = (FT_UShort)( flags >> 15 );
dontAdvance = (FT_UShort)( ( flags >> 14 ) & 1 );
reserved = (FT_Short)( flags & 0x3FFF );
markOffset = (FT_Short)( glyphOffset.ul >> 16 );
currentOffset = (FT_Short)( glyphOffset.ul );

View File

@ -179,6 +179,7 @@
lig_action = FT_NEXT_ULONG( p );
last = (FT_UShort)( ( lig_action >> 31 ) & 1 );
store = (FT_UShort)( ( lig_action >> 30 ) & 1 );
offset = lig_action & 0x3FFFFFFFUL;
}
}
@ -204,6 +205,7 @@
setComponent = (FT_UShort)( ( flags >> 15 ) & 1 );
dontAdvance = (FT_UShort)( ( flags >> 14 ) & 1 );
offset = (FT_UShort)( flags & 0x3FFFU );
if ( 0 < offset )

View File

@ -87,8 +87,9 @@
FT_UShort offset;
GXV_LookupValueDesc value;
/* XXX: check range */
offset = (FT_UShort)(base_value.u + relative_gindex * sizeof ( FT_UShort ));
/* XXX: check range? */
offset = (FT_UShort)( base_value.u +
relative_gindex * sizeof ( FT_UShort ) );
p = valid->lookuptbl_head + offset;
limit = lookuptbl_limit;

View File

@ -164,8 +164,10 @@
markedIsKashidaLike = FT_BOOL( ( flags >> 12 ) & 1 );
currentInsertBefore = FT_BOOL( ( flags >> 11 ) & 1 );
markedInsertBefore = FT_BOOL( ( flags >> 10 ) & 1 );
currentInsertCount = (FT_Byte)( ( flags >> 5 ) & 0x1F );
markedInsertCount = (FT_Byte)( flags & 0x001F );
currentInsertList = (FT_UShort)( glyphOffset.ul >> 16 );
markedInsertList = (FT_UShort)( glyphOffset.ul );

View File

@ -62,6 +62,7 @@
markFirst = (FT_UShort)( ( flags >> 15 ) & 1 );
dontAdvance = (FT_UShort)( ( flags >> 14 ) & 1 );
markLast = (FT_UShort)( ( flags >> 13 ) & 1 );
reserved = (FT_UShort)( flags & 0x1FF0 );
verb = (FT_UShort)( flags & 0x000F );

View File

@ -124,7 +124,9 @@
setMark = (FT_UShort)( ( flags >> 15 ) & 1 );
dontAdvance = (FT_UShort)( ( flags >> 14 ) & 1 );
reserved = (FT_UShort)( flags & 0x3FFF );
markIndex = (FT_Short)( glyphOffset.ul >> 16 );
currentIndex = (FT_Short)( glyphOffset.ul );
@ -142,10 +144,12 @@
markIndex, currentIndex ));
if ( optdata->substitutionTable_num_lookupTables < markIndex + 1 )
optdata->substitutionTable_num_lookupTables = (FT_Short)(markIndex + 1);
optdata->substitutionTable_num_lookupTables =
(FT_Short)( markIndex + 1 );
if ( optdata->substitutionTable_num_lookupTables < currentIndex + 1 )
optdata->substitutionTable_num_lookupTables = (FT_Short)(currentIndex + 1);
optdata->substitutionTable_num_lookupTables =
(FT_Short)( currentIndex + 1 );
}
@ -154,9 +158,9 @@
GXV_LookupValueDesc value,
GXV_Validator valid )
{
GXV_TRACE(( "morx subtable type1 subst.: %d -> %d\n", glyph, value.u ));
FT_UNUSED( glyph ); /* for the non-debugging case */
FT_UNUSED( glyph );
GXV_TRACE(( "morx subtable type1 subst.: %d -> %d\n", glyph, value.u ));
if ( value.u > valid->face->num_glyphs )
FT_INVALID_GLYPH_ID;
@ -176,7 +180,8 @@
GXV_LookupValueDesc value;
/* XXX: check range? */
offset = (FT_UShort)(base_value.u + relative_gindex * sizeof ( FT_UShort ));
offset = (FT_UShort)( base_value.u +
relative_gindex * sizeof ( FT_UShort ) );
p = valid->lookuptbl_head + offset;
limit = lookuptbl_limit;

View File

@ -176,6 +176,7 @@
lig_action = FT_NEXT_ULONG( p );
last = (FT_UShort)( ( lig_action >> 31 ) & 1 );
store = (FT_UShort)( ( lig_action >> 30 ) & 1 );
offset = lig_action & 0x3FFFFFFFUL;
}
}
@ -203,6 +204,7 @@
setComponent = (FT_UShort)( ( flags >> 15 ) & 1 );
dontAdvance = (FT_UShort)( ( flags >> 14 ) & 1 );
performAction = (FT_UShort)( ( flags >> 13 ) & 1 );
reserved = (FT_UShort)( flags & 0x1FFF );
ligActionIndex = glyphOffset.u;

View File

@ -161,8 +161,10 @@
markedIsKashidaLike = FT_BOOL( ( flags >> 12 ) & 1 );
currentInsertBefore = FT_BOOL( ( flags >> 11 ) & 1 );
markedInsertBefore = FT_BOOL( ( flags >> 10 ) & 1 );
currentInsertCount = (FT_Byte)( ( flags >> 5 ) & 0x1F );
markedInsertCount = (FT_Byte)( flags & 0x001F );
currentInsertList = (FT_Byte) ( glyphOffset.ul >> 16 );
markedInsertList = (FT_UShort)( glyphOffset.ul );

View File

@ -142,7 +142,8 @@
FT_UNUSED( valid );
/* XXX: check range? */
value.u = (FT_UShort)(base_value.u + relative_gindex * 4 * sizeof ( FT_Short ));
value.u = (FT_UShort)( base_value.u +
relative_gindex * 4 * sizeof ( FT_Short ) );
return value;
}

View File

@ -214,7 +214,8 @@
GXV_LookupValueDesc value;
/* XXX: check range? */
offset = (FT_UShort)(base_value.u + relative_gindex * sizeof( FT_UShort ));
offset = (FT_UShort)( base_value.u +
relative_gindex * sizeof( FT_UShort ) );
p = valid->lookuptbl_head + offset;
limit = lookuptbl_limit;

View File

@ -755,6 +755,7 @@
/* */
#define cur_to_org( n, zone ) \
FT_ARRAY_COPY( (zone)->org, (zone)->cur, (n) )
static FT_Error
TT_Hint_Glyph( TT_Loader loader,
FT_Bool is_composite )
@ -762,15 +763,15 @@
TT_GlyphZone zone = &loader->zone;
FT_Pos origin;
#ifdef TT_CONFIG_OPTION_BYTECODE_INTERPRETER
FT_UInt n_ins;
#else
FT_UNUSED( is_composite );
#endif
#ifdef TT_CONFIG_OPTION_BYTECODE_INTERPRETER
FT_UInt n_ins;
n_ins = loader->glyph->control_len;
#endif
origin = zone->cur[zone->n_points - 4].x;
@ -779,16 +780,16 @@
translate_array( zone->n_points, zone->cur, origin, 0 );
#ifdef TT_CONFIG_OPTION_BYTECODE_INTERPRETER
/* save original point positioin in org */
if ( n_ins > 0 )
cur_to_org( zone->n_points, zone );
#endif
/* round pp2 and pp4 */
zone->cur[zone->n_points - 3].x = FT_PIX_ROUND( zone->cur[zone->n_points - 3].x );
zone->cur[zone->n_points - 1].y = FT_PIX_ROUND( zone->cur[zone->n_points - 1].y );
zone->cur[zone->n_points - 3].x =
FT_PIX_ROUND( zone->cur[zone->n_points - 3].x );
zone->cur[zone->n_points - 1].y =
FT_PIX_ROUND( zone->cur[zone->n_points - 1].y );
#ifdef TT_CONFIG_OPTION_BYTECODE_INTERPRETER
@ -1006,6 +1007,7 @@
( subglyph->flags & SCALED_COMPONENT_OFFSET ) )
#endif
{
#if 0
/*************************************************************************/
@ -1200,17 +1202,13 @@
FT_Bool opened_frame = 0;
#ifdef TT_CONFIG_OPTION_GX_VAR_SUPPORT
FT_Vector* deltas = NULL;
#endif
#ifdef FT_CONFIG_OPTION_INCREMENTAL
FT_StreamRec inc_stream;
FT_Data glyph_data;
FT_Bool glyph_data_loaded = 0;
#endif
@ -1280,7 +1278,7 @@
#if 0
/* GWW: Do I do the same for vertical metrics ??? */
/* GWW: Do I do the same for vertical metrics? */
metrics.bearing_x = 0;
metrics.bearing_y = top_bearing;
metrics.advance = advance_height;
@ -1292,7 +1290,7 @@
top_bearing = (FT_Short)metrics.bearing_y;
advance_height = (FT_UShort)metrics.advance;
# endif
#endif /* 0 */
}